Incubator-superset: Shifting cursor (forward) when editing Markdown with emoji

Created on 19 Oct 2020  ·  6Comments  ·  Source: apache/incubator-superset

When editing a markdown component with a specific emoji (which occupies two characters) - for example the start emoji which is by default on the markdown component, clicking on text places the cursor one character to the right and making editing confusing.

Expected results

Cursor stays at correct position

Actual results

Cursor jumps 1 step forward

Screenshots

It's hard without video, but here are few screenshots (I can share video if needed). In this example I am trying to correct "payouss" to "payouts"

Screen Shot 2020-10-19 at 10 16 07 AM
Screen Shot 2020-10-19 at 10 16 25 AM
Screen Shot 2020-10-19 at 10 17 00 AM

How to reproduce the bug

  1. Go to Dashboard, Add Markdown with emoji (e.g. the start shape)
  2. Try to edit a sentences (after the emoji) and see the cursor jumps around (deletes character forward, not correct one)

Environment

  • superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.
#bug .dashboard polidea

All 6 comments

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.69. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc FYI. I know there are other two open bugs for markdown https://github.com/apache/incubator-superset/issues/11304 and https://github.com/apache/incubator-superset/issues/11257 they are all different, just wanted to surface this as it relates to the same component.

@zuzana-vej Thank you, Zuzana for reporting and linking. We will get to it in a couple weeks 🙏

@kkucharc 🙏

I think this is known issue of Ace Editor.
Even it appears when I try put ✨ in their demo:
https://ace.c9.io/
I tried check the newest version of react-ace but it didn't help. I suggest to wait for a fix in the library.

Thanks @kkucharc, closing this bug.

Was this page helpful?
0 / 5 - 0 ratings