Incubator-superset: SQL should display "query preview" by default when user selects schema & table (past behavior)

[zuzana-vej]

In the past when user selects schema and table name, SQL Lab displays list of columns on the left side and switches automatically to "Preview tab", so that the user can preview the data immediately. After the recent changes in SQL Lab, the default tab stays at "Results" (which are SQL Lab query results) so user needs to make an extra click to switch to the preview tab to preview their data.

Expected results

Tab automatically switches to "Preview: table-name"

Actual results

Tab remains as "Results"

Screenshots

1. user selects schema & table
   

2. Default tab should change to "Preview: table-name" (this was past behavior)
   

How to reproduce the bug

1. Go to SQL Lab
2. Select schema in the picker on left side
3. Select table name
4. List of columns loads properly; the tab stays at "Results" instead of switching to "Preview" so that user can preview data

Environment

(please complete the following information):

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [x] I have reproduced the issue with at least the latest released version of superset.
• [x] I have checked the issue tracker for the same issue and I haven't found one similar.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.82. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[mistercrunch]

@junlincc this could be related to recent antd <Tab/> work by @kgabryje (?)

[kgabryje]

I'll check it out!

[kgabryje]

@zuzana-vej @mistercrunch Here's a fix: https://github.com/apache/incubator-superset/pull/11343

[zuzana-vej]

@kgabryje thank you!

[rusackas]

Fix merged!

[zuzana-vej]

I am still seeing the issue. Switching tabs works. But in the past, when user selects a table name on left side from the schema, it automatically switched to the tab with the preview. Currently the tab shows up, but user needs to manually switch.

Is this new behavior as designed or a bug?

Image 1: Searching for the table I selected

Image 2: See the data preview isn't default tab

[kgabryje]

@zuzana-vej Are you sure you're testing it on the latest master? For me it works exactly like you expect (see gif).

[zuzana-vej]

Yes latest master, just synced it yesterday. Using Chrome.

[kgabryje]

@zuzana-vej I'm sorry, but I cannot reproduce it 🙁 Does anybody else still experience this issue?

[zuzana-vej]

Yeah. No problem. I'll close this and if necessary reopen. Thanks for checking @kgabryje
EDIT: confirmed works as expected thank you!