Incubator-superset: Non-chart owners should not be able to edit chart properties

Created on 15 Oct 2020  路  2Comments  路  Source: apache/incubator-superset

Currently when users edit a chart they are not an owner of, they can still change things in the Edit Properties modal, but when they save, it will report "an error occurred". We should either hide the Edit icon or disable all inputs.

Screenshots

image

How to reproduce the bug

  1. Edit a chart that you are not an owner of
  2. Edit chart properties and change the owner
#bug

Most helpful comment

I opened https://github.com/apache/incubator-superset/pull/11381 which is not a perfect fix, but it should make things a little less confusing.

All 2 comments

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.89. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

I opened https://github.com/apache/incubator-superset/pull/11381 which is not a perfect fix, but it should make things a little less confusing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vylc picture vylc  路  3Comments

XiaodiKong picture XiaodiKong  路  3Comments

ghost picture ghost  路  3Comments

thoralf-gutierrez picture thoralf-gutierrez  路  3Comments

shyam2794 picture shyam2794  路  3Comments