Incubator-superset: Dashboard CSS keeps disappearing for v0.37

[stevensuting]

Expected results

Once CSS is written on the Dashboard CSS feature, it should remain persistent.

Actual results

The CSS once applied reflects on the dashboard for the current session. In the subsequent login the CSS script disappears. The number of sessions are arbitrary. Sometimes it happens after one session, sometimes after several.

Screenshots

Before

After

How to reproduce the bug

1. Go to Dashboards -> Edit Record -> Scroll to CSS text box
2. Paste some CSS, like

.grid-container{
    margin: 18px;
}
.dashboard-header {
display: none;
}

1. Save and go to Dashboard.
2. You will see the CSS changes. Now log out and log back in, CSS disappears.

Environment

• superset version: 0.37
• python version: 3.6.9

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [ Y] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [ Y] I have reproduced the issue with at least the latest released version of superset.
• [ Y] I have checked the issue tracker for the same issue and I haven't found one similar.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

🙏 @rusackas

[gtg472b]

I think this has already been fixed. I had the issue a couple of months ago, but it's no longer a problem for me.

[willbarrett]

I think this is related to https://github.com/apache/incubator-superset/issues/10655

[i2cute]

I also facing the same problem. What is the solution for this?

[willbarrett]

Some members of the community are working on a refactor of the related code, there are a number of related data handling issues. We do not have an ETA for completion or release, but the problem is being actively worked on.

[squalou]

Same issue here, 0.37.2

[squalou]

update : appears as fixed for me in 0.38.0, not tested all use cases yet but edit / add css / does persist things

[stevensuting]

I noticed when the CSS gets erased. It's not session based but rather caused by editing an existing dashboard.

If you build a dashboard, add CSS then save. The CSS stays for good.
If you edit a dashboard that has some CSS; on saving it erases all the CSS.