Incubator-superset: Editing chart properties causes dashboards to become un-linked to the chart

Created on 6 Aug 2020  路  7Comments  路  Source: apache/incubator-superset

When you edit chart properties via the "edit properties" modal, it breaks any dashboards the chart appears in.

Expected results

The chart would still be associated with the dashboard

Actual results

The chart is no longer associated with the dashboard

Screenshots

Screen Shot 2020-08-05 at 5 13 41 PM
These two charts were edited, changing the title and the cache timeout

How to reproduce the bug

  1. Add a chart to a dashboard
  2. Use the "edit properties" modal to edit the chart
  3. The chart is no longer associated with the dashboard

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.
#bug .pinned polidea

Most helpful comment

I think it's a backend bug. After making a PUT request to /api/v1/chart/${slice_id} , the modified chart is not returned in the response to Dashboard view (or rather in data-bootstrap which is server-rendered).
@kkucharc Could you take a look?

All 7 comments

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

https://github.com/apache/incubator-superset/issues/11623

@kgabryje let's address these two issues together

Is this still an issue?

yes, i tested when i filed #11623 @mistercrunch
Screen Shot 2020-11-09 at 10 01 29 PM

On it

I think it's a backend bug. After making a PUT request to /api/v1/chart/${slice_id} , the modified chart is not returned in the response to Dashboard view (or rather in data-bootstrap which is server-rendered).
@kkucharc Could you take a look?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

XiaodiKong picture XiaodiKong  路  3Comments

sashank picture sashank  路  3Comments

josephtyler picture josephtyler  路  3Comments

shyam2794 picture shyam2794  路  3Comments

gbrian picture gbrian  路  3Comments