Incubator-superset: can't add clickhouse database (allways connecting as default user)

[janantos]

Can't add ClickHouse database under databases. when pressing Test Connection button receiving error message that User default is not allowerd to connect. there is set another user in SQLAlchemy URI (user name containing dash "-")

Expected results

receive successful status

Actual results

receive error message

Screenshots

How to reproduce the bug

1. Go to Sources -> Databases
2. Click on '+' button
3. fill Database and URI
4. press Test Connection

Environment

(please complete the following information):

• superset version: 0.28.14
• python version: 3.6.8
• sqlalchemy-clickhouse version: 0.1.5.post0

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [ x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [ x] I have reproduced the issue with at least the latest released version of superset.
• [ x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

also tested using clickhouse-sqlalchemy 0.0.10 it does not fails during check connection but after clicking save button, I receive error "Could not locate column in row for column 'name' "

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.82. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[ericandrewmeadows]

Have you tried this on 0.33.0rc1? I believe this may help.

[ognemuh]

We've tried this on version 0.34 (python/alchemy are the same) - still doesn't work.

[villebro]

I was able to reproduce the Could not locate column in row for column 'name' error - will investigate.

[villebro]

The problem with saving a database seems to be in clickhouse-sqlalchemy. Please see the following ticket: https://github.com/xzkostyan/clickhouse-sqlalchemy/issues/64 On the other hand sqlalchemy-clickhouse seemed to work better (was able to add the engine), so you might want to try that out.

[janantos]

I have found solution.
You need to downgrade infi.clickhouse_orm to version 1.0.4 and then it will
work.

Also you will be receiving errors about decimal data types, his can be
solved with installing sqlalchemy-clickhouse from GitHub and not from PIP.
You can install it using pip command.

Also in superset 0.34 the SQL Lab save as table functionality will not
work, as Clickhouse does not use standard SQL.

On Fri, 30 Aug 2019, 15:11 Yury Saulin, [e-mail] wrote:

We've tried this on version 0.34 (python/alchemy are the same) - still
doesn't work.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/7991?email_source=notifications&email_token=AETNTFVTC7PAZNMMKOBFWQLQHEE5HA5CNFSM4IJTKFS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RO3YQ#issuecomment-526577122,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AETNTFTPIU3LU3TFZ6HQW5TQHEE5HANCNFSM4IJTKFSQ
.

[villebro]

FYI, I have a fix in the works for clickhouse (bug in how connection string is constructed), will put through a PR later today.

[janantos]

I do not understand why this bug does not exhibit on infi.clickhouse_orm <=1.04. what has changed in higher versions?

[villebro]

This got messier than expected, mostly due to poor standardization in the python dbapi spec, hence my issues were mostly unrelated to clickhouse. Will be looking at those later. However, while I was able to get SqlLab working with clickhouse, I was unable to add tables using the stable version from PyPI or the bleeding edge version from github. Were you successful with that?

[janantos]

yes I have been successful, as mentioned earlier.
I have found solution. You need to downgrade infi.clickhouse_orm to version 1.0.4 and then it will work. Also you will be receiving errors about decimal data types, his can be solved with installing sqlalchemy-clickhouse from GitHub and not from PIP. You can install it using pip command. Also in superset 0.34 the SQL Lab save as table functionality will not work, as Clickhouse does not use standard SQL.

[janantos]

Both of this has been tested using 0.29b7 from PIP and 0.34 from GitHub

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[ameyd12]

I think I have run into a similar issue here as the connection string to Clickhouse looks to be broken

@villebro would appreciate if you have any guidance, if it's a different issue happy to add a new issue.

I did a docker-compose build with sqlalchemy-clickhouse=0.1.5.post0 and infi.clickhouse_orm==1.0.4