Incubator-superset: Viz validation overrides no longer being used

[jaylindquist]

PR #7231 updated visualization validation to take place in the exploreReducer.js SET_FIELD_VALUE action. This validation does not take into account any controlOverrides on the visualization.

Specifically, the Table viz removes any validatation from the metrics row control. This means attempting to create a Table with only "Not Grouped By" columns fails.

Expected results

Be able to create a Table visualization with only "Not Grouped By" columns

Actual results

Creating any Table without a "Metrics" results in an error

Screenshots

How to reproduce the bug

1. Create a Table Visualization
2. Delete "Group by" and "Metrics" values
3. Add "Not Grouped By" columns

Environment

Master branch as of April 22 (commit: 845218dd88ad2fe1284dcb7427c5bff20749dc74)

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [x] I have reproduced the issue with at least the latest released version of superset.
• [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

n/a

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[ali-bahjati]

I think we should reopen this issue and it's important to fix.

[first-caveman]

+1 on this. I am able to skirt around the issue by first defining "Not Grouped By" columns, and then clearing the 'Metrics' field.

[axelet]

The other way to workaround is to change Vis Type to something else and change is back to Table. Or just select Table explicitly (even if it is already selected) after Explore page loaded before changing any settings.

[mistercrunch]

I could not reproduce on master. Loaded up a table chart and cleared Metrics field.

[axelet]

@mistercrunch I also tested on master and it doesn't reproduce for me either when loading from a chart. But on the other hand when going through Sources -> Tables, choosing birth_names, for example, and clearing COUNT metric, it does appear for me (tested on Chrome, Opera).

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.