Incubator-superset: Do we still need syncBackend.json?

Created on 2 Apr 2019  路  2Comments  路  Source: apache/incubator-superset

Superset version

master

Expected results

There is a file syncBackend.json and script for generating it.
However, it does not seem to be used anywhere.

If there is any need for it, please comment here. Otherwise I propose we delete syncBackend.json and the accompanying script within a week.

Most helpful comment

95% sure that the answer is no, and I also think we won't need it in the future. Global environment configurations live in superset_config.py, and we have a mean to share a subset to the frontend that works well.

I can give a shot at killing it.

All 2 comments

95% sure that the answer is no, and I also think we won't need it in the future. Global environment configurations live in superset_config.py, and we have a mean to share a subset to the frontend that works well.

I can give a shot at killing it.

Reading through the code, we only need the logic that is in there to support migrations from 2+ years ago (feb 2017), and provided that they would first upgrade to a bridge version (anywhere from pre 2017 to something between then and our next version) they'd be ok.

Also needed to support full bookmarks (the long ones, not shortened) from 2+ years ago versions.

I vote for pulling the plug on this one.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ylkjick532428 picture ylkjick532428  路  3Comments

XiaodiKong picture XiaodiKong  路  3Comments

john-bodley picture john-bodley  路  3Comments

sashank picture sashank  路  3Comments

thoralf-gutierrez picture thoralf-gutierrez  路  3Comments