some PRs get pr-awaiting-merge label when CI passes and it already has an approval, but others dont when the approval comes after the CI has already completed.
https://github.com/apache/incubator-mxnet/pull/19669
@samskalicky Thanks for reporting
NA
1.Review a PR after CI has passed.
NA
@mxnet-label-bot update [bug]
Cause of issue: Currently, Github webhook only sends events related to "Status"
https://issues.apache.org/jira/browse/INFRA-20624
What does Status event cover?
Commit status updated from the API
Basically, any change that happens to the commit status [CI running/success/failure]
However, PR review event is not part of Statuses event.
Next Steps
- Create a request for updating github webhook for PR Status Label to send events related to PR Review
There are 3 options
1. Pull request reviews
Pull request review submitted, edited, or dismissed.
Pull request diff comment created, edited, or deleted.
Pull request opened, closed, reopened, edited, assigned, unassigned, review requested, review request removed, labeled, unlabeled, synchronized, ready for review, converted to draft, locked, or unlocked.
Out of the 3, 1st one is the most applicable. It's necessary & sufficient.
Ticket created: https://issues.apache.org/jira/browse/INFRA-21193
Most helpful comment
Ticket created: https://issues.apache.org/jira/browse/INFRA-21193