Incubator-mxnet: PR Status Labeler Bot doesn't get triggered by reviews

Created on 15 Dec 2020  路  3Comments  路  Source: apache/incubator-mxnet

Description

some PRs get pr-awaiting-merge label when CI passes and it already has an approval, but others dont when the approval comes after the CI has already completed.

https://github.com/apache/incubator-mxnet/pull/19669

@samskalicky Thanks for reporting

Error Message

NA

Steps to reproduce

1.Review a PR after CI has passed.

What have you tried to solve it?

  1. Manually label the PR using label-bot

Environment

NA

Bug

Most helpful comment

All 3 comments

@mxnet-label-bot update [bug]

Cause of issue: Currently, Github webhook only sends events related to "Status"
https://issues.apache.org/jira/browse/INFRA-20624

What does Status event cover?

Commit status updated from the API

Basically, any change that happens to the commit status [CI running/success/failure]
However, PR review event is not part of Statuses event.

Next Steps
- Create a request for updating github webhook for PR Status Label to send events related to PR Review
There are 3 options
1. Pull request reviews

Pull request review submitted, edited, or dismissed. 
  1. Pull request review comments
Pull request diff comment created, edited, or deleted. 
  1. Pull requests
Pull request opened, closed, reopened, edited, assigned, unassigned, review requested, review request removed, labeled, unlabeled, synchronized, ready for review, converted to draft, locked, or unlocked. 

Out of the 3, 1st one is the most applicable. It's necessary & sufficient.

Was this page helpful?
0 / 5 - 0 ratings