Incubator-mxnet: MKLDNN header missing in mxnet-cu102==1.7.0 pip package

[vycezhong]

I encountered an compilation error showing that is not found when I tried to compile BytePS with mxnet-cu102==1.7.0. I checked the mxnet package and indeed there is no MKLDNN header.

However, interestingly I found that it supports MKLDNN. And later I found MKLDNN is enabled by default in 1.7.0. https://github.com/apache/incubator-mxnet/pull/16899

So I suggest including the headers in the pip package.

[bartekkuncer]

Hi @vycezhong,
I saw that there was simillar issue in the past: https://github.com/apache/incubator-mxnet/issues/18120, which has been fixed here: https://github.com/apache/incubator-mxnet/pull/18310 and https://github.com/apache/incubator-mxnet/pull/18355. I will check why this issue is occurring again.
Thanks for reporting.

[bartekkuncer]

I have checked that the fix has been applied to branch v1.7.x but not to the tag 1.7.0 which apparently is used to build the pip package.

[bartekkuncer]

Please try using: https://repo.mxnet.io/dist/python/cu102/mxnet_cu102-1.7.0b20200813-py2.py3-none-manylinux2014_x86_64.whl. I believe it has all necessary headers.

[vycezhong]

Please try using: https://repo.mxnet.io/dist/python/cu102/mxnet_cu102-1.7.0b20200813-py2.py3-none-manylinux2014_x86_64.whl. I believe it has all necessary headers.

Thanks for your help.

[bartekkuncer]

Please try using: https://repo.mxnet.io/dist/python/cu102/mxnet_cu102-1.7.0b20200813-py2.py3-none-manylinux2014_x86_64.whl. I believe it has all necessary headers.

Thanks for your help.

@vycezhong I understand that the package I proposed works for you? :)

@szha @leezu Should we release patch v1.7.1 which will fix the lacking headers or just wait for official minor v1.8.0 release?

[vycezhong]

Yes it works for me. Thanks.

[szha]

@bartekkuncer I think we should. At least it should be fixed with a post-release

[bartekkuncer]

@bartekkuncer I think we should. At least it should be fixed with a post-release

@szha Ok, I will look into it. What is the post-release flow?

[szha]

@bartekkuncer it's just about repackaging and releasing on PyPI as another version. Since there is some ongoing license issue that needs to be sorted out first, we are putting changes to PyPI changes on hold. Will revisit once the issue is resolved.