Immer: Change source code to TypeScript

[styfle]

I noticed you have the typescript devDependency but the source code is written in JS.
Any reason why you didn't write it in TS?

[mweststrate]

None other than that it started out really tiny and I initially only
targeted recent Node versions

Op di 16 jan. 2018 om 19:18 schreef Steven [e-mail]:

I noticed you have the typescript devDependency but the source code
https://github.com/mweststrate/immer/blob/master/src/index.js is
written in JS.
Any reason why you didn't write it in TS?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mweststrate/immer/issues/67, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhP0f5IATfwz5Z1Glxqgxy_9C5kXBks5tLOfjgaJpZM4RgNmD
.

[styfle]

Ok maybe if I have time, I'll write a PR to convert to TypeScript 😃

[mweststrate]

Such change is welcome, but ping me beforehand (or wait a few days). I am
currently shoving a lot of code around to improve code reuse / build

Op di 16 jan. 2018 om 19:35 schreef Steven [e-mail]:

Ok maybe if I have time, I'll write a PR to convert to TypeScript 😃

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/mweststrate/immer/issues/67#issuecomment-358061200,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhOjuRs91pMv-BSjrSuGu9JTgKaVTks5tLOvzgaJpZM4RgNmD
.

[sebasgarcep]

Seeing as how TS is oriented towards OO code and Flow towards FP code, wouldn't it make more sense to add Flow typings instead?

[styfle]

Seeing as how TS is oriented towards OO code and Flow towards FP code, wouldn't it make more sense to add Flow typings instead?

What makes you say that? TypeScript works great for FP code and I haven't run into anything it couldn't do.

[mweststrate]

That sounds like a weird distinction to make between the two. But yes there
is an open issue to add flow typings, just didn't get to that yet :)

Op wo 17 jan. 2018 om 20:42 schreef Sebastian Garrido <
[email protected]>:

Seeing as how TS is oriented towards OO code and Flow towards FP code,
wouldn't it make more sense to add Flow typings instead?

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/mweststrate/immer/issues/67#issuecomment-358420344,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhJsPu6mS0d-RTMuf9ONjvp-TO6FBks5tLk08gaJpZM4RgNmD
.

[sebasgarcep]

@styfle I don't doubt TS capabilities, I've used it before and it is great, but Flow brings a different set of guarantees and capabilities. I just thought the author might want to check it out before deciding on which option suits this project better.

[mweststrate]

Ok, the code base should be pretty stable now. PR is welcome

[mweststrate]

@Gregjarvez sure, feel free to submit a PR :)

[pqkluan]

JS support both OOP and FP. Why we have to focus on single perspective to decide the support the static types checker?

Here is the comparison between Typescript and Flow.

IMHO, Typescript is more stable in term of performance (my experience with IntelliSense on vs-code), better syntax, and supported by many large projects. Plus, we could support TypeScript type definitions in a seperate package if needed.

[urish]

@mweststrate do you know if anybody is working on this?

If not, please leave a comment at urish/typewiz#35 and I'd love to do this for you.

[mweststrate]

@urish PR welcome (doesn't seem anybody is working on it) :)

[urish]

@mweststrate excellent, I saw your comment. I will be working on the PR tomorrow. Fun ahead!

[urish]

See #128 - basically, all the TS setup is there (code is TS, builds and tests pass), though I haven't added any new type annotations yet (except for few fixes to make the code compile).

[mweststrate]

Closing for now, could be reopened if somebody feels for it :)