Image-sequencer: Upgrade to bootstrap 4
Please describe the problem (or idea)
We currently use bootstrap 3.7. Bootstrap 4 has some significant improvements/changes. Let's upgrade to v4.
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
harshkhandeparkar
All 34 comments
big change! But yeah, we can -- our HTML is relatively minimal. +1 after we
get the Bootstrap pane UI merged!
On Sun, Mar 24, 2019 at 4:23 PM Harsh Khandeparkar notifications@github.com
wrote:
Please describe the problem (or idea)
We currently use bootstrap 3.7. Bootstrap 4 has some significant
improvements/changes. Let's upgrade to v4.
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping
refine and improve this site.To learn how to write really great issues, which increases the chances
they'll be resolved, see:https://publiclab.org/wiki/developers#Contributing+for+non-coders
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/938, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AABfJ1CZRYJXdjw1UFRsVATGYoV7CYs4ks5vZ96XgaJpZM4cFu2-
.
jywarren
on 25 Mar 2019
I will do this :smile:
harshithpabbati
on 26 Mar 2019
Should I do it or leave to some new comers they may do it ???
harshithpabbati
on 26 Mar 2019
I think you should do this as this is a relatively difficult task. What do you say?
harshkhandeparkar
on 26 Mar 2019
Ok fine then I will do this!!
harshithpabbati
on 26 Mar 2019
Can I work on this?
ananya
on 26 Mar 2019
Fine then you can.
harshithpabbati
on 26 Mar 2019
But you need to wait for some time. Let the panel be merged and then you can start your work !!!
harshithpabbati
on 26 Mar 2019
Thank you :smiley: Let me know once I can start working
ananya
on 26 Mar 2019
@ananya you can start working with it :tada:
harshithpabbati
on 29 Mar 2019
@Harshithpabbati yeah okay :smiley: I will start working on this in the coming week.
ananya
on 30 Mar 2019
@ananya check the name 😂
harshithpabbati
on 30 Mar 2019
haha fixed :stuck_out_tongue:
ananya
on 30 Mar 2019
My localhost is looking like this on installing the project. Is it fine or I am missing something?
ananya
on 2 Apr 2019
No. It looks like this.
harshithpabbati
on 2 Apr 2019
Your branch is not upto date. Pull the changes.
Thanks!
harshithpabbati
on 2 Apr 2019
My branch is upto date. I just have to "npm run setup" and "npm start" after cloning the project right?
ananya
on 2 Apr 2019
I think you have cloned jywarren/image-sequencer. Clone publiclab/image-sequencer
harshkhandeparkar
on 2 Apr 2019
@HarshKhandeparkar its publiclab/image-sequencer only
ananya
on 2 Apr 2019
Could it be a caching issue? Thanks for working together to figure this out!
On Tue, Apr 2, 2019 at 12:37 PM Ananya Agrawal notifications@github.com
wrote:
[image: Screenshot from 2019-04-02 22-05-52]
https://user-images.githubusercontent.com/33188930/55419953-84518800-5593-11e9-85bd-ca3aad9a0109.png@HarshKhandeparkar https://github.com/HarshKhandeparkar its
publiclab/image-sequencer only—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/938#issuecomment-479084709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJzH4GMhktn76gcjeW9cA5M2DWnRhks5vc4c6gaJpZM4cFu2-
.
jywarren
on 2 Apr 2019
Service worker doesn't even work right now.
harshkhandeparkar
on 2 Apr 2019
@ananya try git fetch upstream first.
harshkhandeparkar
on 2 Apr 2019
You can also run
git fetch upstream
git reset --hard upstream/main
Bur be careful as this will overwrite any existing changes
harshkhandeparkar
on 2 Apr 2019
But I am still seeing intermittent saved caches when testing things... so
wondering if it could be an issue!
On Tue, Apr 2, 2019 at 12:42 PM Harsh Khandeparkar notifications@github.com
wrote:
You can also run
git fetch upstream
git reset --hard upstream/mainBur be careful as this will overwrite any existing changes
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/938#issuecomment-479086874,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2642SYP2_PUdXUKbT7lPtnSGwLlks5vc4hVgaJpZM4cFu2-
.
jywarren
on 2 Apr 2019
@ananya what browser ro you use?
harshkhandeparkar
on 2 Apr 2019
@Harshithpabbati i am on chrome
ananya
on 2 Apr 2019
Is that chrome or chromium? Try upgrading it to the latest version.
harshkhandeparkar
on 2 Apr 2019
Is it tye latest version?
harshkhandeparkar
on 2 Apr 2019
it is chrome. And I tried to fetch also but it is still showing the same page.
ananya
on 2 Apr 2019
Also can you run ls in a terminal and provide a screenshot of the output?
harshkhandeparkar
on 2 Apr 2019
Btw, did you try clearing the cache?
harshkhandeparkar
on 2 Apr 2019
It worked somehow :smiley: . Though this was the result i got when i installed the project for the first time, then how could this be a cache problem :thinking:
ananya
on 2 Apr 2019
Maybe it cached once when your project was not up to date? Who knows but anyways I'm glad that you managed to fix it👍. Feel free to ask any other queries as well. 😊
harshkhandeparkar
on 2 Apr 2019
Oh Okay. Thank you for the help :smiley:
ananya
on 2 Apr 2019
Related issues
jywarren
·
4Comments
kindanduseful
·
5Comments
harshkhandeparkar
·
4Comments
jywarren
·
4Comments
keshav234156
·
4Comments
Most helpful comment
@ananya you can start working with it :tada: