Image-sequencer: There's a problem with exportBin

[tech4GT]

cc @jywarren @HarshKhandeparkar @Divy123

[Divy123]

Looking into it.

[Divy123]

I am unable to see the image variable declared in the whole file neither has it been passed.

[tech4GT]

Hmm, never mind I found it.

[Divy123]

What have you found out?

[tech4GT]

Pushing in a fix now, please be careful to test the project via all the clients in the future, we don't want broken code on npm right.

[tech4GT]

it should be "image" not image

[Divy123]

Ya that should work!!

[Divy123]

Actually I think there is a confusion.
I never changed anything in this file.
So this problem might be existing from some earlier parts.
@tech4GT
Really thankful that you pinned it out.
Will take care next time.

[tech4GT]

That's okay, I did not mean you broke something, just wanted to say it's good practice to test for all clients before pushing to npm.

[Divy123]

Thanks for always helping and guiding.
Just got a bit scared.
I will be writing a workflow for webgl shim issue there.
Please help there to create a right workflow on things as majority of the hinderances have been figured out.
@tech4GT

[jywarren]

Thanks all! Was there a test we might write to protect this in the future?

We're also still seeing an error on addsteps in the demo, I wanted to try
to fix that but also add a test to protect it as well. Now that we have
test suites for all clients as well as UI, we can get much higher test
coverage and this sort of thing will happen less. Thanks again!

On Wed, Mar 20, 2019, 8:49 AM Slytherin [e-mail] wrote:

Thanks for always helping and guiding.
I will be writing a workflow for webgl shim issue there.
Please help there to create a right workflow on things as majority of the
hinderances have been figured out.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/899#issuecomment-474814264,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJydJVVVjVkiXwGwgY15Yy1PSzY88ks5vYi4hgaJpZM4b_L7O
.

[Divy123]

Can you tell which kind of error in addSteps, the responsiveness one?

[tech4GT]

Hi jeff, I redid the import-image using another instance of sequencer to load the image. If that’s okay we can merge and publish to npm since the current code is not working on CLI

[tech4GT]

Btw import-image is now working in node.

[Divy123]

Can you please elaborate on why the CLI part is not working @tech4GT ?
I mean what are the issues?

[jywarren]

Awesome can u bump the version number?

The addsteps error is here:
https://github.com/publiclab/image-sequencer/issues/888

Thanks!

On Wed, Mar 20, 2019, 9:05 AM Slytherin [e-mail] wrote:

Can you please elaborate on why the CLI part is not working @tech4GT
https://github.com/tech4GT ?
I mean what are the issues?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/899#issuecomment-474819768,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ35Gyygth9wMFFtUcLW-g_j7sfLPks5vYjICgaJpZM4b_L7O
.