Image-sequencer: Add step selector too narrow on mobile view

[Divy123]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

To Do: Make the step selector dropdown and add step button responsive.

To Fix

You can have a look here for reference.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file examples/index.html in image-sequencer repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

Diff yet to be added.

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

[harshkhandeparkar]

If a newcomer wants to solve an issue but cannot find one, they can get their name added to the list in #842

[Divy123]

Thanks @HarshKhandeparkar

[harshkhandeparkar]

This issue is reserved for @An0u

[harshkhandeparkar]

@Divy123 @Harshithpabbati @aashna27 can this issue be solved by using bootstrap flex grid? The step selector can be given a class of .col-sm-12 .col-md-8 and the add step btn .col-sm-12 .col-md-4. Is this possible? Also changing selectize dist file directly isn't advisable. Also selectize is actually included through node modules, so no question about editing dist.

[harshithpabbati]

I guess we can do it.

[harshkhandeparkar]

@aashna27 what are your views on this?

[harshkhandeparkar]

I guess we can do it.

So shall we edit the issue?

[harshithpabbati]

@HarshKhandeparkar I just tried it now but we need to even change the width of the option so we have to change in it's own css.

[harshkhandeparkar]

I don't think we need to change the width. Did you try the col classes?

[harshithpabbati]

Yeah I tried it.

[harshithpabbati]

See this is what it's happening even if I use col-xs.

[harshkhandeparkar]

Do you have a screenshot?

[harshkhandeparkar]

It is happening because you are using col-xs. Try adding only .col-sm-12 class.

[harshkhandeparkar]

Please note that the columns have to be eirect children of a .row

[harshithpabbati]

Yeah they are in that row div.

[harshithpabbati]

Oh okay we want them in different lines right???

[harshkhandeparkar]

<div class="row">
  <div class="col-sm-12">
    <div>
       <!-- step selector markup -->
    </div>
  </div>
  <div class="col-sm-12">
    <div>
       <!-- add step btn markup -->
    </div>
  </div>
</div>

[harshithpabbati]

@harshkhandeparkar i did the same thing

[harshkhandeparkar]

How is it not working then? It should work...

[harshithpabbati]

[harshithpabbati]

It's because of the custom width of the selectize.

[harshkhandeparkar]

The add step btn should have full sized....

[harshithpabbati]

May be even that have a particular width

[harshkhandeparkar]

It shouldn't...

[harshkhandeparkar]

Try giving it a style width=100%

[harshithpabbati]

In demo.css it is having max-width:500px; thats the reason.

[harshkhandeparkar]

Oh. Remove that and try...

[aashna27]

I am sorry, a little busy for 2 days I ll get back with a suggestion after
that. I ll try it out before commenting.

On Wed, Mar 27, 2019, 1:50 PM Harsh Khandeparkar [e-mail]
wrote:

@aashna27 https://github.com/aashna27 what are your views on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/894#issuecomment-477031502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZUPyJhmxBygOd491RXfZCN8x1E81jH1ks5vaym8gaJpZM4b8NHV
.

[harshkhandeparkar]

@jmauriciowebdev you can try this one.

[harshkhandeparkar]

fixed