Image-sequencer: When the input is larger make it as textarea

[Paarmita]

In the blend module, the input is the blend function, according to which blending should be done.
So the input area shows function in a single line, it would look good if we can use the text area or some other component for it, instead of input.

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

A possibly related issue is https://github.com/publiclab/image-sequencer/issues/211 (Make an icon for the project).

[gitmate[bot]]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

A possibly related issue is https://github.com/publiclab/image-sequencer/issues/211 (Make an icon for the project).

[tech4GT]

@Paarmita Awesome! I was also thinking about this earlier today, maybe we can create a ui for this module by embedding a light weight text editor into it!

[tech4GT]

Since we expect people to write a complete function in there!

[Ankit-Singla]

@tech4GT I would like to work on this one. May I go ahead and start?

[tech4GT]

@Ankit-Singla Sure!! The one concern I have right now is that the editor needs to be as light weight as possible, so that it does not slow down the page!

[Dhiraj240]

@tech4GT i would like to work on this too.

[tech4GT]

@Dhiraj240 I think Ankit has already started on this one, maybe you guys can collaborate?

[Dhiraj240]

@Ankit-Singla will you collaborate because i probably need help. Can we submit two different PRs for this same issue?

[tech4GT]

I would suggest giving push rights to a a common branch and opening a project from there. Maybe aAnkit-Singla can do that

[Ankit-Singla]

@tech4GT awesome! I'll do this today. Are you okay with this @Dhiraj240 ?

[Dhiraj240]

Alright, as you wish i am here to learn @Ankit-Singla

[Ankit-Singla]

Cool @Dhiraj240
I have created a branch named `inputtextarea' and have invited you to be a collaborator. Please accept the invitation so that we can work on this one together. 😄

[Dhiraj240]

@Ankit-Singla please remove your invitation as i am planning to give a direct PR so if you don't mind then i am working on it as already several days have passed without working.Let me give it a try and if i am not able to reproduce this issue, i will assign you.

[Ankit-Singla]

Sure @Dhiraj240 go ahead!

[Divy123]

Is this issue still open @tech4GT ? I would link to work upon it.

[tech4GT]

@Divy123 Yes it is!

[Dhiraj240]

@Divy123 Sorry, i had assigned it to myself and will be sending PR soon.

[tech4GT]

Oh, okay had no idea you were still working on this Dhiraj, Divy maybe you can take up another one, I just posted some new issues so do take a look there. Thanks :smile:

[Divy123]

sure @tech4GT :smile:

[Dhiraj240]

@Divy123 you can work on this i am shifting to other projects and will just be reviewing PRs @tech4GT

[Divy123]

@Dhiraj240 sure I will work on this :smile:

[Divy123]

I googled about text editors that can be integrated and found these editors helpful :

• monaco-editor - https://www.npmjs.com/package/monaco-editor
• javascript-editor - https://www.npmjs.com/package/javascript-editor`
• Ace - https://ace.c9.io/
  What would you suggest @tech4GT @Paarmita ?

[jywarren]

I wonder if we might decide to just show a simple textarea element --
could we have the info.json specify longer inputs by using "text" instead
of "string" in lines like this?

https://github.com/publiclab/image-sequencer/blob/89345f32b3dd2cf9f73fedbd03b9d371fbaf35ed/src/modules/ImportImage/info.json#L7

On Sun, Jan 6, 2019 at 2:43 PM Slytherin [e-mail] wrote:

I googled about text editors that can be integrated and found these
editors helpful :

• monaco-editor - https://www.npmjs.com/package/monaco-editor
• javascript-editor - https://www.npmjs.com/package/javascript-editor`
• Ace - https://ace.c9.io/
  What would you suggest @tech4GT https://github.com/tech4GT @Paarmita
  https://github.com/Paarmita ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/389#issuecomment-451768751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4iqSbnZFHpdB4_VH1R7kU5ODU5uks5vAlG_gaJpZM4XK2fA
.

[Divy123]

Yeah that's cool to proceed like this. So should I proceed in this direction?

[harshkhandeparkar]

I wonder if we might decide to just show a simple textarea element -- could we have the info.json specify longer inputs by using "text" instead of "string" in lines like this? https://github.com/publiclab/image-sequencer/blob/89345f32b3dd2cf9f73fedbd03b9d371fbaf35ed/src/modules/ImportImage/info.json#L7

@jywarren there is an issue open for this https://github.com/publiclab/image-sequencer/issues/570

[Divy123]

Sure @HarshKhandeparkar but we are still on discussion. Also I think its not that same.

[harshkhandeparkar]

@Divy123 what I meant by my comment was that we cannot change the type property directly from here. That has to be resolved first. This way we can resolve any conflicts or new bugs.

[Divy123]

Surely your idea is quite good at issue #570 but as I get since this issue is still under discussion, we are yet discussing about text-editor and text-area thing.

[harshkhandeparkar]

Ya just wanted to make sure that no confusion occurs. Sorry for disturbing.

On 08-Jan-2019 7:55 PM, "Slytherin" [e-mail] wrote:

Surely your idea is quite good at issue #570
https://github.com/publiclab/image-sequencer/issues/570 but as I get
since this issue is still under discussion, we are yet discussing about
text-editor and text-area thing.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/389#issuecomment-452316077,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhKOn1l6AL-f-I9uT9hEJsgbR0v5T3e6ks5vBKo8gaJpZM4XK2fA
.

[Divy123]

No problem @HarshKhandeparkar . We all here to contribute so all the views are more than welcome.

[harshithpabbati]

can i work on this??

[Divy123]

@Harshithpabbati
I have already opened a PR for this. Please look into some other issue.
Thanks, we will be happy to get your contributions.