Image-sequencer: get CLI to run synchronously for chainability

[jywarren]

If there's any way to configure commander to be synchronous, and wait for the callback, that'd be good so that the commandline version is chainable -- like:

sequencer -i photo.jpg && mv photo.jpg ~/Desktop/

https://npmjs.org/package/commander

[tech4GT]

I would like to work on this issue

[jywarren]

That'd be super, thank you!

On Jan 18, 2018 11:44 PM, "Varun Gupta" [e-mail] wrote:

I would like to work on this issue

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-358865306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4O5rImUQYLpFUdMljoUJs3BMTsXks5tMB2LgaJpZM4PuVQb
.

[tech4GT]

@jywarren do we want to draw progress bar and loading icon?

[jywarren]

That sounds really cool! Let's open a separate issue for it though, so we
can solve things modularly;
https://publiclab.org/notes/warren/01-18-2018/software-outreach-modularity-is-great-for-collaboration

That'd be a perfect next step after this one. Great idea!

On Sat, Jan 20, 2018 at 12:05 AM, Varun Gupta [e-mail]
wrote:

@jywarren https://github.com/jywarren do we want to draw progress bar
and loading icon?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-359146113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJzUxrbTk1Ubrpf321USPl1XHRYYMks5tMXQKgaJpZM4PuVQb
.

[tech4GT]

Amazing read @jywarren

[tech4GT]

@jywarren should i open the issue?

[jywarren]

Yes please! Thanks!!

On Jan 21, 2018 11:42 AM, "Varun Gupta" [e-mail] wrote:

@jywarren https://github.com/jywarren should i open the issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-359261741,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5TLp5RAPwXCSDu-MRVm6h2Xizs_ks5tM2jjgaJpZM4PuVQb
.

[tech4GT]

@jywarren can you please elaborate on this issue a little. If we store the output image in the same directory, wouldn't that make it chainable too?

[jywarren]

What i've seen is that if you run sequencer -i photo.jpg && mv photo.jpg ~/Desktop/ and the initial sequencer command takes any time at all, the mv command will run before sequencer is done, since it's asynchronous. So I just want to suggest we make it synchronous -- only return complete once the output file is ready -- so that it can be used in shell script command chaining. Does that make sense?

[tech4GT]

@jywarren Cool, that makes perfect sense, I will start looking for a workaround now.
Thankyou

[jywarren]

:-) thank you!!!

On Tue, Jan 23, 2018 at 10:14 AM, Varun Gupta [e-mail]
wrote:

@jywarren https://github.com/jywarren Cool, that makes perfect sense, I
will start looking for a workaround now.
Thankyou

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-359821260,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1b_cpAcz80bY1hmjDv_xmoelM9sks5tNfc7gaJpZM4PuVQb
.

[tech4GT]

@jywarren i think this is happening because our node process exits after calling all the async code, so we need to stop the node process from finishing before the images are exported, we can use es6 features for that.
If we declare exportbin function as async and await it in index.js then we can exit the process after the images are exported
Please guide me if my thinking is correct?

[jywarren]

Sure, i think that sounds good. I thought there was a way to run a function
synchronously somehow, but this sounds just as good. Thanks!

On Sun, Feb 4, 2018 at 6:22 AM, Varun Gupta [e-mail]
wrote:

@jywarren https://github.com/jywarren i think this is happening because
our node process exits after calling all the async code, so we need to stop
the node process from finishing before the images are exported, we can use
es6 features for that.
If we declare exportbin function as async and await it in index.js then we
can exit the process after the images are exported
Please guide me if my thinking is correct?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-362910233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxEDaEsOoWr-TgtLXT4aj-ba9KXkks5tRb0xgaJpZM4PuVQb
.

[tech4GT]

@jywarren we would have to change quite a bit of code to es6 i hope it's fine?😅

[jywarren]

would that affect browser support?

On Mon, Feb 5, 2018 at 11:00 AM, Varun Gupta [e-mail]
wrote:

@jywarren https://github.com/jywarren we would have to change quite a
bit of code to es6 i hope it's fine?😅

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-363129429,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_O10adtuqc5RpWWZyeWz-gxsag4ks5tRyW2gaJpZM4PuVQb
.

[tech4GT]

@jywarren It will not work with internet explorer and maybe some very old versions of other browsers, will that be ok?

[jywarren]

I wonder -- based on what we use already right now, what version of IE do
we support?

On Mon, Feb 5, 2018 at 9:21 PM, Varun Gupta [e-mail]
wrote:

It will not work with internet explorer, will that be ok?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-363288803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJyOM-qJEazMMAfgWtHDh17dz3Piqks5tR7cbgaJpZM4PuVQb
.

[tech4GT]

[jywarren]

This sounds great then!

[tech4GT]

@jywarren I think there was some error earlier, i just tried chaining commands and it worked. I tried it with edge detection which takes some time to process and it still worked. I moved the output of the sequencer to desktop and it worked😅
node ./index.js -i ../imgs/myImage.png -s "edge-detect" && mv ./output/sequencer101/image1_1.png ../

[jywarren]

Oh, so it's already chainable then?????!!

[tech4GT]

Yes if we use a double &😁

[jywarren]

Ah, that makes sense! Let's add that to the docs. Great!

On Feb 20, 2018 8:07 PM, "Varun Gupta" [e-mail] wrote:

Yes if we use a double &😁

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-367177645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ74YVtmXrGoRWWGf6RL0faB9stNkks5tW2ttgaJpZM4PuVQb
.

[tech4GT]

Sure I'm opening another issue for that...this one can be closed😁

[tech4GT]

@jywarren But the initial example that you took won't work because of the long cli syntax, i have put it in my proposal in detail
https://publiclab.org/notes/tech4gt/02-19-2018/gsoc-proposal-image-sequencer-v2-processing-on-steroids

[jywarren]

Sorry, can you explain that here? Just copy in your explanation?

does not support naming of the output image

is the key, right?

[tech4GT]

@jywarren yeah sure,
Yes you are right that's the key and we also export the images in a "sequencer + " folder which makes it difficult to access the output on the fly, also i am planning to implement extension detection which will make it possible to name output of a .jpg image as .png and it will be automatically exported as png. For eg
sequencer -i "photo.jpeg" -s "invert" -n "photo.png"
will output a photo.png which will be the inverted image of photo.jpeg

[jywarren]

oh awesome!

On Wed, Feb 21, 2018 at 12:07 PM, Varun Gupta [e-mail]
wrote:

yeah sure,
Yes you are right that's the key and we also export the images in a
"sequencer + " folder which makes it
difficult to access the output on the fly, also i am planning to implement
extension detection which will make it possible to name output of a .jpg
image as .png and it will be automatically exported as png. For eg
sequencer -i "photo.jpeg" -s "invert" -n "photo.png"
will output a photo.png which will be the inverted image of photo.jpeg

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/image-sequencer/issues/130#issuecomment-367397982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_GauFWTROeWVqQfk8p8WBHE4V10ks5tXE1FgaJpZM4PuVQb
.

[tech4GT]

@jywarren i think we can close this one now, thanks😁

[jywarren]

Perfect, thanks.

[jywarren]

Should we create an issue for -o being used to specify an output filename?

-o | --output [PATH] | Directory where output will be stored. (optional)

[tech4GT]

@jywarren we can do that but i would be doing that in the summer anyway