Iina: Trackpad or MagicMouse scroll can't change volume above 100.

Created on 2 Jun 2017  路  3Comments  路  Source: iina/iina



System and IINA version:

  • macOS 10.12.5
  • IINA 0.0.9

Expected behavior:
Trackpad or Magic Mouse vertical scroll change volume to maximum value specified user preference.


Actual behavior:
When changing volume via trackpad or magic mouse, volume does not change above 100.
Even if I specified maximum volume to above 100 (eg. 130) in Preference panel.
However Up and Down arrow keys are worked as expected. They can change volume above 100.

  • Crash report:

  • MPV log:


Steps to reproduce:

  • [x] MPV does not have this problem.


How often does this happen?
Always

Needs code change setVolume function in PlayerCore.swift file.

original code

  func setVolume(_ volume: Double, constrain: Bool = true) {
    let constrainedVolume = volume.constrain(min: 0, max: 100)

change to...

  func setVolume(_ volume: Double, constrain: Bool = true) {
    let constrainedVolume = volume.constrain(min: 0, max: mpvController.getDouble(MPVOption.Audio.volumeMax))

Most helpful comment

What is the purpose of allowing to change volume over 100 by keyboard only?
Why not just keep behavior consistently and simple, let users change volume any way they want, as I know, apps like Movist allow user scrolling from 0 to MAX, and I have never encountered problem with that.

All 3 comments

same here, It is also true using a logitech mouse(g303).

@darkbrow @chenjau
Initially this was a design feature to allow increasing volume over 100 only with arrow keys.
I posted some comments and suggestions on this behavior at #694, please comment and thumbs up if you find my ideas interesting.

What is the purpose of allowing to change volume over 100 by keyboard only?
Why not just keep behavior consistently and simple, let users change volume any way they want, as I know, apps like Movist allow user scrolling from 0 to MAX, and I have never encountered problem with that.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ugoa picture ugoa  路  3Comments

Pash237 picture Pash237  路  3Comments

edwardfhsiao picture edwardfhsiao  路  3Comments

element515 picture element515  路  3Comments

alashow picture alashow  路  3Comments