Ignite: Fix mypy issue with pytorch nightly

Created on 9 Nov 2020  路  3Comments  路  Source: pytorch/ignite

馃悰 Bug description

Currently, there is an issue with running mypy on ignite when using pytorch-nightly :

 ignite/distributed/comp_models/native.py:334: error: Incompatible types in
assignment (expression has type "ReduceOp", variable has type "str") 
[assignment]
                op = self._reduce_op_map[op]
                     ^
Found 1 error in 1 file (checked 84 source files)

https://github.com/pytorch/ignite/runs/1373059337#step:5:17

@gruebel could you please take a look if we can fix it ? Thanks

bug

All 3 comments

Sure, I can take a look today

Thanks @gruebel ! And couldy you please also remove namedtuple import (https://github.com/pytorch/ignite/pull/1433#discussion_r516991700). I merged too fast that PR :)

yeah, good point. Already forgot about it 馃檲

Was this page helpful?
0 / 5 - 0 ratings

Related issues

andreydung picture andreydung  路  4Comments

vfdev-5 picture vfdev-5  路  3Comments

Sudy picture Sudy  路  4Comments

vfdev-5 picture vfdev-5  路  4Comments

Aiden-Jeon picture Aiden-Jeon  路  3Comments