Ignite: MyPy: improve ignite.base module

Created on 3 Oct 2020  路  5Comments  路  Source: pytorch/ignite

馃殌 Feature

Currently, mypy ignores all errors for all modules. We have to rework our typing such that mypy checks the code.
In this issue, let's improve https://github.com/pytorch/ignite/tree/master/ignite/base module such that mypy passes on it.

For Hacktoberfest contributors, feel free to ask questions for details if any and say that you would like to tackle the issue.
Please, take a look at CONTRIBUTING guide.

Hacktoberfest enhancement help wanted
Source
picture vfdev-5

All 5 comments

Hey, would love to contribute! I've read through the contributing guide & should be able to complete this over the weekend.

thescripted picture thescripted on 3 Oct 2020
👍1

Thanks @thescripted ! Let me assign it to you.

vfdev-5 picture vfdev-5 on 3 Oct 2020

@thescripted will you work on this issue today or tomorrow ? As we have another PR dependent on this issue, it would be nice to have this one resolved quickly.

vfdev-5 picture vfdev-5 on 5 Oct 2020

Writing up a PR as we speak (:

thescripted picture thescripted on 5 Oct 2020
👍1

@thescripted thanks !

vfdev-5 picture vfdev-5 on 5 Oct 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

alykhantejani picture alykhantejani  路  3Comments
UjwalKandi picture UjwalKandi  路  3Comments
samarth-robo picture samarth-robo  路  3Comments
vfdev-5 picture vfdev-5  路  3Comments
jphdotam picture jphdotam  路  4Comments