Iglistkit: Cannot compile iOS example app

[Ricardo1980]

Hello,

I'm trying to compile the example apps following this guide: https://instagram.github.io/IGListKit/
I download the current IGListKit version, then I run "./scripts/setup.sh" but I see this error:

Setting up example projects...
Setting up iOS examples...
Analyzing dependencies
2020-01-19 14:46:39.693 defaults[10716:3505260] 
The domain/default pair of (/Users/ricardo/Downloads/IGListKit-master/Source/Info, CFBundleShortVersionString) does not exist
[!] The `IGListDiffKit` pod failed to validate due to 1 error:
    - ERROR | version: A version is required.

Any advice? What should I do to compile the iOS example app?

Thanks a lot.

New issue checklist

• [x] I have reviewed the README and documentation
• [x] I have searched existing issues and this is not a duplicate
• [x] I have attempted to reproduce the issue and include an example project.

General information

• IGListKit version: 4.0.0
• iOS version(s): iOS 13 and 12
• CocoaPods/Carthage version: cocoapods 1.8.4
• Xcode version: 11.2.1
• Devices/Simulators affected: NA
• Reproducible in the demo project? (Yes/No): I guess so, I cannot compile it.
• Related issues:

[sclcoder]

I encountered the same problem. This may be caused by the MAC OS 10.15 shell.
I'm not familiar with shell, I just used a little trick to solve this problem. After all, just run the demo, there is no need to spend too much time.
Just modify the IGListDiffKit.podspec 、IGListKit.podspec、IGListSwiftKit.podspec files

s.version = scripts/version.sh to s.version = '4.1.0'

[JackieQi]

Just to highlight here. Fixed in this commit https://github.com/Instagram/IGListKit/pull/1423/commits/9253d54cc639759f6a7fc52fded80a95bac03c29

[lorixx]

Thanks for surfacing this @JackieQi !

[richardtop]

+1 definitely a demo project should take less than a minute to run.

[yspreen]

I see your PR was closed @damozhang, did you open a new one that complies to the repo's conventions?

To me, the master branch still creates this issue... Paging @JackieQi as well?

[VincentSit]

This issue is reproducible on macOS 11.1 / 11.2, @JackieQi 's patch does fix it.