Iglistkit: Failing test

Created on 29 Jun 2018  路  3Comments  路  Source: Instagram/IGListKit

@rnystrom It looks like commit a1ee4c19f7a6cbd9899dba82deb5fb3ece669e9c add the test test_withDuplicateDiffIdentifiers_thatDuplicatesAreRemoved and it is failing.

bug
Source
picture zhubofei

All 3 comments

@zhubofei thanks for flagging! We'll get this working ASAP.

rnystrom picture rnystrom on 9 Jul 2018
❤1

@rnystrom Maybe we should reverse the commit entirely? objectsWithDuplicateIdentifiersRemoved will always assert when there are duplicate ids under DEBUG. And I think maybe we shouldn't remove dup objects on our end and leave users unnoticed.

zhubofei picture zhubofei on 9 Jul 2018
👍1

Fixed bee2178443ffcaff1d9135c4e094f74240433a62

zhubofei picture zhubofei on 13 Jul 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  路  3Comments
runmad picture runmad  路  3Comments
jessesquires picture jessesquires  路  3Comments
shuhrat10 picture shuhrat10  路  3Comments
PhilCai1993 picture PhilCai1993  路  3Comments