Iglistkit: Update CONTRIUBUTING.md

[rnystrom]

https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md

Let's add:

• How we do major and minor releases:
  
  
  
  • https://github.com/Instagram/IGListKit/issues/471#issuecomment-278161714
  
  
• A "launch checklist" template (e.g. #471)
• Testing philosophy (total coverage)
• Update coding style
  
  
  
  • Restrict subclassing (objc macro, final in examples)
  
  
  • ivars v props
  
  
  • local vars instead of self.prop over & over
  
  

Anything I'm missing?

[jessesquires]

https://github.com/Instagram/IGListKit/blob/master/.github/RELEASE_CHECKLIST.md

😄

[agisilaos]

Gonna start with this one instead! Already updated the Coding Style with the 3 new bullets. What you exactly mean with the "Testing Philosophy" @rnystrom? so I can be on the same page with you.

[rnystrom]

Good point I should have documented that:

Basically we want 99% test coverage at all times. So if you're adding new stuff, get it tested.

When fixing bugs, try your hardest to recreate the bug in a unit test, then fix the test. This sets us up to never regress that issue again.

[agisilaos]

Update Contributing.md aka Task list:

• [x] How we add major and minor releases #471 (comment)
• [x] A "launch checklist" template (e.g. #471)
• [x] Testing philosophy (total coverage)
• [x] Update coding style
  - Restrict subclassing (objc macro, final in examples)
  - ivars v props
  - local vars instead of self.prop over & over

[agisilaos]

Ok, gonna add that with the Title: Testing philosophy and the points you mentioned :)

[agisilaos]

Ok here's the Pull request I just made: https://github.com/Instagram/IGListKit/pull/558