Iglistkit: Unit test background color on IGListCollectionView

Created on 7 Dec 2016  路  5Comments  路  Source: Instagram/IGListKit

We landed a couple commits to avoid changing the background to white when using storyboards or UIAppearance:

However they are only tested w/ eyeballs. We should add unit tests to prevent regressions.

bug starter-task

Most helpful comment

I'll write the tests. I've got dinner plans tonight, but can get it done by Thursday night if that works.

All 5 comments

@jessesquires think this needs to be part of 2.0.0? Or since 2.0.0 is stable w/ this feature we just add the tests in whenever we can get to it.

cc original authors @jeffbailey and @dcaunt

+1 for doing tests now.

also, need to update CHANGELOG?

I'll write the tests. I've got dinner plans tonight, but can get it done by Thursday night if that works.

@jessesquires not sure if we should update the changelog since this fixed a feature we added in 2.0.

@jeffbailey that'd be great!

done in b9ede32f5be71bed87b0d82c3cb7e50daa6444ea

Was this page helpful?
0 / 5 - 0 ratings

Related issues

racer1988 picture racer1988  路  16Comments

rafalszastok picture rafalszastok  路  18Comments

jessesquires picture jessesquires  路  19Comments

rnystrom picture rnystrom  路  24Comments

aortegas picture aortegas  路  16Comments