Iglistkit: Add examples for ASDK, ComponentKit, etc.

Created on 20 Oct 2016  路  14Comments  路  Source: Instagram/IGListKit

Follow up task from #86.

Add examples using:

  • [ ] ComponentKit
  • [ ] AsyncDisplayKit
  • [ ] UIKit
  • [ ] WKWebView

鈿狅笍 If submitting a PR, please submit 1 PR per type of example

enhancement starter-task

Most helpful comment

@Sherlouk: there is another ASDK example here, pretty similar to the IGListKit search example https://github.com/facebook/AsyncDisplayKit/tree/master/examples_extra/RepoSearcher

All 14 comments

@jessesquires are you gonna work on this?

lol. didn't mean to self-assign

In #86, @rnystrom mentioned using ComponentKit, AsyncDisplayKit, UIKit, and WKWebView within the same list. Is that still the goal or should four different lists be created, each using one of the aforementioned frameworks?

Here's my stab at simple ComponentKit integration: https://github.com/ocrickard/IGListKit-ComponentKit/blob/master/IGListKit-ComponentKit/CKComponentSectionController.mm

This has an item controller that can render an arbitrary number of sub-elements using ComponentKit. Uses async processing of components by default, but could easily be changed to support synchronous/asynchronous modes.

@ocrickard / @rnystrom

We could add a CocoaPods subspec with a dependency on ComponentKit and add these IGLK+ComponentKit components (assuming they're reusable)

Would be super cool to explore

Has anyone taken a look at creating the AsyncDisplayKit example? Looking to try and improve feed performance and interested in anyones experience.

@stevejcox To my knowledge @Adlai-Holler was looking into this?

Mentioned it here: https://github.com/Instagram/IGListKit/pull/375

@stevejcox Hi, yep we've got it up and running, with an example. We're looking for comments, so please give it a try if you want! https://github.com/facebook/AsyncDisplayKit/pull/2848

Fantastic @Adlai-Holler ! I'll give it a whirl.

@jessesquires @rnystrom

Are we still wanting to bring examples into this repo? As linked there are examples for two of the listed tasks:

If so, do we want them as a different project file entirely, or add it all to the Examples-iOS project?

We could add a CocoaPods subspec with a dependency on ComponentKit

Do we want to do this (IGListKit/ComponentKit)? Same for ASDK (IGListKit/AsyncDisplayKit)?

@Sherlouk: there is another ASDK example here, pretty similar to the IGListKit search example https://github.com/facebook/AsyncDisplayKit/tree/master/examples_extra/RepoSearcher

@MarvinNazari Thanks for linking that one. hadn't seen it! Much easier to move over (already in Swift)

B/c there are existing and examples, and we want to limit the scope of things we support within the repo directly, I'm going to close this out. Those examples are great, and I'm happy to promote and link to more as they come up. Just don't want to get our examples overly complicated for now.

Was this page helpful?
0 / 5 - 0 ratings