Identityserver4: Year 2038 problem in nbf and exp

Created on 12 Nov 2018  路  4Comments  路  Source: IdentityServer/IdentityServer4

Issue / Steps to reproduce the problem

If we look into that lines https://github.com/IdentityServer/IdentityServer4/blob/nuget_2.3.0-preview2/src/Validation/Default/TokenValidator.cs#L452-L453 we will see, that reference token nbf and exp claims values comes from calling .ToEpochTime extension method from IdentityModel https://github.com/IdentityModel/IdentityModel2/blob/3.10.1/src/EpochTimeExtensions.cs#L16, which returns Int32, instead of Int64.
I think it should return Int64, or have additional extension method, that returns Int64.

feature request

Most helpful comment

done on branch. Will be merged into 3.0

All 4 comments

Will switch to the .NET built-in ones in v3

https://identitymodel.readthedocs.io/en/latest/misc/epoch_time.html

Looks like a lot has been updated to use long, but where we emit claims we need to change to use ClaimValueTypes.Integer64.

done on branch. Will be merged into 3.0

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings