Identityserver4.admin: Add French (fr) localization

Created on 5 Aug 2019  路  11Comments  路  Source: skoruba/IdentityServer4.Admin

I'm willing to create the French localization.

Currently i'm working on setting up everything correctly before the PR.

task

Most helpful comment

Translation done (118 fr.resx files and 2 culture files).

I'll double check my work and test it before PR.

All 11 comments

Perfect, thanks! 馃槉

Thanks for the fast answer!

Do you think it would be pertinent to keep the english names for the OAuth concepts or use the french microsoft translations ?

Examples :

Api scope => 脡tendue de l'Api
Client claim => Revendication client

The devs arround me suggest that i keep english names.
French article about OAuth v2 using that style :
https://www.nexworld.fr/securiser-api-oauth2/

This is really good question. I've checked the our current translations and we are using this types of translation like you mentioned: Api scope => 脡tendue de l'Api. Maybe it would be great - create same style of translation. :)

Thanks!

For most words i can find an equivalent but there are cases where i have absolutely no idea.
And if i translated them directly it would feel weird.

  • Subject ID
  • Persisted Grant
  • Device Authorization Flow
  • Client/User claim
  • Identity resource

Thanks for the insight, i will see what i can adapt !

For sure, if you don鈥檛 have an equivalent, please use english term, this is absolutely fine. 馃憤馃徏 Thanks!

Translation done (118 fr.resx files and 2 culture files).

I'll double check my work and test it before PR.

Question: Did you encounter issues with ModelBinding using the Delete logs feature?
On my side, it works if i set the UI to English, but it fails when i set it to French because MM/dd/yyyy is not a valid french date format.
Seems like the DatePicker used in this page doesn't change locale to match selected language.

EDIT: Yeah, seems like the DatePicker's locale never changes. For example, if i switch to russian, i get this:
image

Pretty sure August is not right in russian! hehe

Opened a new issue (#343).

I didnt test the Delete logs feature.

Nice finding about the DatePicker !

I fixed it in PR #345

Done on dev branch. :)
Thanks for your work guys! 馃憤
I will merge it to master.

I am closing this issue, it was released in master branch. Thank you 馃憤馃徏

Was this page helpful?
0 / 5 - 0 ratings

Related issues

maythamfahmi picture maythamfahmi  路  4Comments

ekjuanrejon picture ekjuanrejon  路  4Comments

we4sz picture we4sz  路  4Comments

Aegide picture Aegide  路  4Comments

Hens94 picture Hens94  路  4Comments