Identityserver4.admin: Add new project with API management

Created on 1 Nov 2018  路  12Comments  路  Source: skoruba/IdentityServer4.Admin

Add new project - Skoruba.IdentityServer4.Admin.Api:

  • Create a list of API controllers - for managing of the IdentityServer4 and Asp.Net Core Identity
  • Add swagger support
high task

Most helpful comment

I am working on API:
https://github.com/skoruba/IdentityServer4.Admin/tree/feature/api
I am using the shared business logic from MVC project, but with new mapping for API dtos.

Currently still in progress, but with high priority. :)

All 12 comments

hello @skoruba

any plans on this?

Hi @ekjuanrejon
In the future yes, but if you want to start with this task, feel free send a PR. :)
Thanks!

  • Create projects:

    • Skoruba.IdentityServer4.Admin.Api

    • Skoruba.IdentityServer4.Admin.Api.BusinessLogic - There will be great to reuse the existing repositories (#250) and create new services for API, including new Dtos etc.

@skoruba why can't the business logic of the mvc and the api be shared?

On another note. I see that mvc uses a bit of reflection. Not how how it will play with the api and swagger.

That is great question, I think some of Dtos are very specific for views in MVC app, thefore I am thinking about this separation.
But you are right, maybe it would be fine - create shared business logic layer for both - mvc and api. I will try to consider it.
Good point. :)
Which part of code with reflection do you mean?
Thanks!

The missing APIs are the only feature that devalues this product from competition. The company I work for are unfortunately having to evaluate another product because we need those APIs and are under so much time pressure we cannot currently dedicate the time to PR the functionality. 馃槥

馃憤 on reusing logic.

Thanks for your feedback, I will work on it. :)

I'd like to start taking a look at this and offer some help. I worked on a project for myself that implemented a free UI for the PolicyServer... would be good to implement that all together. I'll start taking a look around of what you have already. Awesome stuff!

Great, if you want to help, it would be perfect. 馃憤

I am working on API:
https://github.com/skoruba/IdentityServer4.Admin/tree/feature/api
I am using the shared business logic from MVC project, but with new mapping for API dtos.

Currently still in progress, but with high priority. :)

Done, please take a look at new release. 馃憤馃徏
Thanks.

Ah fantastic @skoruba ! I'll have a good look asap.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

weedkiller picture weedkiller  路  4Comments

ekjuanrejon picture ekjuanrejon  路  4Comments

yiskang picture yiskang  路  3Comments

xmichaelx picture xmichaelx  路  4Comments

gokayokutucu picture gokayokutucu  路  3Comments