It would be nice to support Doctrine Query Language, or at least suppress the error generated by PhpStorm on the colon within DQL and make the entities clickable. There's a ticket opened on JetBrains YouTrack to support DQL.
completion is blocked inside sql statement. we need to wait for api changes here. i will request it...
well, couldn't you implement it as a separate injected language ? DQL is technically not SQL
good idea, there are already many languages (sql dialects) inside com.intellij.sql, but i dont see an extension point for registering, so need to check first...
<lang.parserDefinition language="MySQL" implementationClass="com.intellij.sql.dialects.mysql.MysqlParserDefinition"/>
Considering DQL is so close to HQL, it may be worth looking into how HQL is implemented?
not that easy to implement our own one, but thats the only way to go.
package com.intellij.sql.dialects.hsqldb
:+1: for this
+1
This would be great. Why? I'm using doctrine's INSTANCE OF within the query for querying the discriminator within inheritance mapping. Obviously INSTANCE OF is not valid SQL.
+1 - would be most useful, I work around the highlighting errors at the moment
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
and another +1. it would be incredibly useful
yet another +1
+1
+1
+1; thanks
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
All the +1s don't help implementing this. It's a complex thing. And it's obvious people want this.
Don't take the +1 negatively, actually it just a gesture from who are
showing their interest in the issue. - It's a good thing, and if or when it
gets implemented a lot of people will be very happy.
On Sep 26, 2015 4:57 PM, "Thomas Schulz" [email protected] wrote:
All the +1s don't help implementing this. It's a complex thing. And it's
obvious people want this.—
Reply to this email directly or view it on GitHub
https://github.com/Haehnchen/idea-php-symfony2-plugin/issues/230#issuecomment-143461342
.
I don't take it negatively, but it puts more pressure on @Haehnchen
The +1s here are the only way to show how many people want the feature. I see this on many github issues and on other feature request software that doesn't provide an alternative to saying "+1" to let the developer know they are also rooting for this.
This allows the developer to prioritise new features by how popular the demand for them is. +1s are helpful in this regard.
I also don't think, given the popularity of developers saying "+1", that this is the most appropriate place to try and oppose that.
I totally agree
On Sep 26, 2015 7:41 PM, "James Mallison" [email protected] wrote:
The +1s here are the only way to show how many people want the feature. I
see this on many github issues and on other feature request software that
doesn't provide an alternative to saying "+1" to let the developer know
they are also rooting for this.This allows the developer to prioritise new features by how popular the
demand for them is. +1s are helpful in this regard.I also don't think, given the popularity of developers saying "+1", that
this is the most appropriate place to try and oppose that.—
Reply to this email directly or view it on GitHub
https://github.com/Haehnchen/idea-php-symfony2-plugin/issues/230#issuecomment-143475031
.
This would indeed be very nice!
+1
One more +1 :)
yet another +1 :+1: :)
+1
+1
+1
+1
(no pressure, just letting know i would be very happy as well)
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
Everyone who want to write a :+1: on this issue from now on should prefer to send @Haehnchen an amazon giftcard or some other nice thing. This is just not helpful at all.
@mablae this wouldn't be an open source at all)
@velikanov Or submit a PR for sure.
+1
Guys, instead of commenting only +1, Github now has the awesome functionality to add a thumbs up to the first post :+1: So do that, to keep the issue somewhat clean :smiley:
So… the year has passed away…
I bet that in a year this functionality… still won't be implemented lol :)
@velikanov Yeah, definitely you should prepare some Pull Request.
Or maybe you think "For what I'm paying?", but wait... you payed nothing...
So instead of lamenting, check source code and start implementing what are you needing, or spend some $$$ for bounty to encourage someone to work on it.
@Szpadel, why me?
Maybe you?
If I want some functionality - that doesn't mean that I'm able to implement it.
Why don't you give everyone here some $$$ to encourage everyone?
:+1:
I wish that for Christmas (2016 ;D) :santa:
:+1:
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
+1
++
Guys, just using query builder, it autocompletes properly
+1
You can specifically ignore DQL by using a carefully crafted SQL injection in your PHPStorm. I have created a Gist with the SQL injection here:
https://gist.github.com/willemnviljoen/d20ad8ad0cc365a7e80744328246610f
This works by matching the same expression as the built-in SQL injection, but excluding any queries which contain a : character. That should make it ignore most DQL queries. This won't get you autocomplete, but at least it will stop marking DQL as an error.
+1
+1
Guys, instead of commenting only +1, Github now has the awesome functionality to add a thumbs up to the first post 👍 So do that, to keep the issue somewhat clean 😃
@Haehnchen maybe you can lock this thread?
@hoshsadiq AFAIK, locking a thread also prevents adding reactions
@hoshsadiq And the issue is still 'open', correct?
+1
JetBrains announced they'd support DQL.
https://plugins.jetbrains.com/plugin/11137-dql-support -> that may be the new plugin for the support.
JetBrains announced they'd support DQL.
https://plugins.jetbrains.com/plugin/11137-dql-support -> that may be the new plugin for the support.
Note that the plugin can only be installed in 2018.3 EAP at this moment
@Haehnchen, is it worth closing this now that JetBrains has picked this up? I haven't touched PHP/Symfony for a while, so I'm not sure what the deal is.
With the latest EAP we’ve provided a new version of DQL plugin with some new features: see https://blog.jetbrains.com/phpstorm/2018/11/phpstorm-2018-3-eap-183-4139-30/ . Give it a try and please share your feedback!
Most helpful comment
Guys, instead of commenting only +1, Github now has the awesome functionality to add a thumbs up to the first post :+1: So do that, to keep the issue somewhat clean :smiley: