Id: Label field is messed up

Created on 10 May 2019  Â·  8Comments  Â·  Source: openstreetmap/iD

Screen Shot 2019-05-10 at 1 37 03 PM

bug field usability

Most helpful comment

This reminds me, we should really add a man_made=manhole tag for these.

I know the wiki doesn't say to, but it's dumb for manhole=* to be a toplevel tag, and makes more sense for it to nest under man_made=*.

All 8 comments

This reminds me, we should really add a man_made=manhole tag for these.

I know the wiki doesn't say to, but it's dumb for manhole=* to be a toplevel tag, and makes more sense for it to nest under man_made=*.

Hi @quincylvania and @bhousel, I am taking a look into that. Thanks!

Hello @quincylvania, I have a question. As you can see from the attached screenshot, currently under Label a textarea element is rendered. Is that correct?
I am seeing that others like Operator as well Reference Code have input elements.
Screenshot 2019-05-12 at 18 03 01

@rodolv1979 I see it as a textarea as well, but it does not look like your screenshot but the one from quincylvania above (Chrome, Mac). It looks like the label-key was added with this preset about 2 years ago as a textarea – https://github.com/openstreetmap/iD/commit/3ebb90a9d278a6c037d6ecd551da071ca2b24043#diff-1373b3b5742f4d2a477bf8d5cc0c6e51R860.

I wonder, what does the label-key stand for? Maybe it could just be removed.

unknown: manhole cover with unknown markings, or of unknown use. Combine with label=* when possible for later identification.

@tordans thank you for your answer. You have right about the screenshot but It is different because I removed the bug (mostly a css job). That screenshot is coming from _my local env_.
However, your question is targeting the main issue here. How it should look like, from an UI and UX point of view. Also the right clickable Info Icon does not work, in practice it does not render any meaningful info.

Also the right clickable Info Icon does not work, in practice it does not render any meaningful info.

You mean it just stays "Label."? That is not a bug. iD just pull https://wiki.openstreetmap.org/wiki/Item:Q366 which does not have good content, yet. – For more on how this works, see https://github.com/openstreetmap/iD/issues/6310#issuecomment-489921050.

Ok, I guessed wrongly, thanks for the link.
I am not so that familiar with this very cool project.

@rodolv1979 Thanks for looking into this! It was more than just a CSS issue so I just took care of it.

Was this page helpful?
0 / 5 - 0 ratings