Id: Warn if feature mismatches because of geometry

[matkoniecz]

Currently amenity=bank node used as a building corner is neither treated as a bank nor triggering a validator warning. Currently it results in a bit confusing handling of this situation.

Given that tagging is dubious second is probably preferable.

See https://www.openstreetmap.org/edit?editor=id&node=2065667950#map=19/36.70793/4.03434

Note difference between BNP Paribas bank and Société Générale bank (displayed with a black dot icon).

Obviously, most of features are unsuitable to be used on a nodes of a building area - banks are not unique and warning may be more general.

[bhousel]

Yes, I agree it would be good to warn about situations like this.

[quincylvania]

I'm thinking we can make this validation part of "Lines Tagged as Areas" and give it a better name like "Mismatched Geometry".

[quincylvania]

I'm thinking we can make this validation part of "Lines Tagged as Areas" and give it a better name like "Mismatched Geometry".

I did this and added warnings for both points-as-vertices and vertices-as-points.

[tordans]

@quincylvania this looks great.

I wonder, might this be a case for the "Extract" Action as a second link-action (next to the "Ignore this issue")?

From the initial example by matkoniecz at https://preview.ideditor.com/master/#background=Maxar-Premium&disable_features=boundaries&locale=en&map=19.00/36.70793/4.03434&node=2065667950 the extract would be a good way to solve the issue.

[quincylvania]

I wonder, might this be a case for the "Extract" Action as a second link-action (next to the "Ignore this issue")?

Yep, good suggestion. This is followup work.

[quincylvania]

I wonder, might this be a case for the "Extract" Action as a second link-action (next to the "Ignore this issue")?

I added this. Makes for an easy fix!

[Lukas458]

But what is, when the feature has the tags support=wall_mounted and location=outdoor, e. g. a veding machine like this https://www.openstreetmap.org/node/1261048099 ?

Isn't it allowed there to make this feature as a member of a building=*-way? I don't understand why it should not. You can add location=outdoor to denote that the feature isn't in the building.

[quincylvania]

@Lukas458 These warnings are based on preset tags. If you're seeing an erroneous warning then we can consider updating the geometry types allowed for the preset in question.

[Lukas458]

@Lukas458 These warnings are based on preset tags. If you're seeing an erroneous warning then we can consider updating the geometry types allowed for the preset in question.

Yes, i think that's what I'd be fine with. I understand sense of those warnings for some presets but still not for vending machines.