Id: Mapillary window: resizing doesn't work properly.

[BjornRasmussen]

To reproduce:
1) Open a mapillary image with preview.ideditor.com/master
2) Make the window of the image larger.
3) Observe this:

[tordans]

_A bit of debugging:_ I could not see any relevant css that is different from osm.org to preview. So I guess its not about the reworked css for the panels (that was recently, right). Maybe it has to do with https://github.com/openstreetmap/iD/pull/6166? Not from the release notes, though (https://github.com/mapillary/mapillary-js/releases). But they did change a lot with https://blog.mapillary.com/update/2019/04/16/mjs-combined-panning.html.

[quincylvania]

Yeah, I'm not sure this is an iD-specific issue. Note that a workaround is to resize the viewer, close it, then reopen it.

[quincylvania]

@cbeddow Any thoughts on this?

[tohaklim]

I remember this happening quite a while ago, then seemingly fixed, and now it's back again - Mapillary codebase changes?..

[cbeddow]

It seems like a CSS conflict, but not clear as mentioned. MapillaryJS should automatically upgrade itself, but we'd want to debug and find the current version. Can we check somehow if it's 2.18.0? When you resize, then MJS calls a resize() function on itself, but maybe is trying to target the wrong div, or an empty variable. I assume overall it may be some lag time causing this to not find what it's trying to resize sometimes.

[carstenhag]

It would be great if this would be fix. I now need to open another tab which is prett annoying.

[cbeddow]

Testing today for me as well and not working here. I will see if we can get this fixed ASAP but it probably is a failure to recognize the window resize and apply .resize() to the Mapillary viewer div.

[carstenhag]

Thanks!

Quincy Morgan [e-mail] schrieb am Do., 22. Aug. 2019,
17:20:

Closed #6286 https://github.com/openstreetmap/iD/issues/6286 via 7d9f732
https://github.com/openstreetmap/iD/commit/7d9f73275315045a72e8c6fb92adcb0ea9d1086b
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openstreetmap/iD/issues/6286?email_source=notifications&email_token=AA42DZPCH7L5G6ORTA5BOW3QF2VDTA5CNFSM4HJZMV4KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTGMAREI#event-2576877713,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA42DZMYF6CPTOG32L5UTB3QF2VDTANCNFSM4HJZMV4A
.

[quincylvania]

This turned out to be an iD issue after all. Oops!

The viewer resize event was only getting sent to the last viewer to register for it. This also meant that Bing Streetside images would get stretched instead of scaled. Congrats to OpenStreetCam on landing last alphabetically 😅

Thanks for your patience on this everyone!