Id: Combobox should toggle on clicking anywhere on the field, not just the carat

Created on 13 Dec 2018  路  7Comments  路  Source: openstreetmap/iD

Click on fields should show list of options. In the previous release, click on a field in the sidebar after selecting something showed list of options, now it doesn't work. We have to click on the arrow to show list of options. It would be great we can have the old behavior.

usability

Most helpful comment

I agree to 'phiphou', the behavior before was nice, if you want to have quick access to the dropdown items.
Could you please link to the issue, for what reason did you change it? What was the disadvantage of the behavior before?

Maybe it would be a compromise to increase & clear separation (add a vertical line) of the carat area...

All 7 comments

Click on fields should show list of options. In the previous release, click on a field in the sidebar after selecting something showed list of options, now it doesn't work. We have to click on the arrow to show list of options. It would be great we can have the old behavior.

Users can still press the up/down keys, click the carat, or start typing in order to get the menu to pop up.

I think the new behavior is a lot more in line with how other comboboxes/dropdowns work on other sites. Can we just try it out this way for a little while?

I use ID every day since three years so this change is a little confusing for me. But I will maybe accustom with this new behavior, even if I find the old behavior more convenient. Please let the ticket opened in order to see who agree with this. (sorry for my bad english, I'm french)

I actually prefer the new behavior. I don't always want to have the dropdown open obtrusively when I click the field to edit directly. Not that I have yet encountered a case where immediately opened dropdown was a problem.

I agree to 'phiphou', the behavior before was nice, if you want to have quick access to the dropdown items.
Could you please link to the issue, for what reason did you change it? What was the disadvantage of the behavior before?

Maybe it would be a compromise to increase & clear separation (add a vertical line) of the carat area...

Maybe it would be a compromise to increase & clear separation (add a vertical line) of the carat area...

I'm planning to make it so that you can click anywhere on the field to toggle the combo (not just on the carat area)

I have to say that I preferred the old behaviour. I didn't have to be so precise about where I clicked to get a list of options. And all I had to do was to start typing to narrow the list down (or make it go away if I wanted a value ID didn't have in its list). I can live with the new behaviour, but I doubt I'll ever prefer it.

@maxgrossman you can look into this one too..
I think it's just that this block of code needs to move from the carat to the input and then the carat should get CSS pointer-events: none so the clicks don't go to it.

https://github.com/openstreetmap/iD/blob/f478fdbfbd3f9cb4f8ddd0b232c78d523dfefc3e/modules/ui/combobox.js#L69-L83

Was this page helpful?
0 / 5 - 0 ratings