Id: Add support for roofs

[egore]

It would be really helpful if iD would support setting the "roof:*" properties similar to how adresses can be edited on buildings.

From what I understood so far "address" is a special type of field. It would be a nice enhancement to allow these multi-value type of field definitions to be done in json as well.

If that would be in place it would be awesome to have:
"roof:shape" as a "combo"
"roof:orientation" as a checkbox for "along/across"
"roof:height" as integer

[stefangrotz]

I would like to implement some improvements for maping buildings, including a way to map roof shapes more easily. I have something in mind that is similar to the graphical aproach of the app streetcomplete:

Where in the code is the edit menu for buildings defined? I would like to try a few things locally and then come back and make some suggestions.

[bhousel]

Where in the code is the edit menu for buildings defined? I would like to try a few things locally and then come back and make some suggestions.

Currently it's just defined as a field that fetches values from taginfo:
https://github.com/openstreetmap/iD/blob/master/data/presets/fields/building.json

[stefangrotz]

Ah I see. Is it possible to put Icons as Labels in theese files or is this a text only field?

[bhousel]

Ah I see. Is it possible to put Icons as Labels in theese files or is this a text only field?

Currently text only, but adding support for icons would be useful.
https://github.com/openstreetmap/iD/blob/master/modules/ui/combobox.js

[stefangrotz]

Does this preset files define wich fields are displayed in the menu? (/presets/presets!)
https://github.com/openstreetmap/iD/blob/6ce2c5ea46b6bb89f8a3a3dd9d5794a920bbf610/data/presets/presets/building.json

[bhousel]

yes, check out the preset README here

[quincylvania]

I added a Roof Color (roof:colour) field in the last release since it's a self-explanatory property that's readily visible in imagery. The other roof: tags would not make very user-friendly fields: