Icevision: Fastcore 1.1 breaking changes

[lgvaz]

🐛 Bug

Describe the bug
Fastcore 1.1 contains a breaking change described here:

• Remove Path.{read,write} (use Path.{read_text,write_text} instead) and change Path.{load,save} to functions load_pickle and save_pickle (#121)

We need to update our calls to Path.read to fix this issue.

[lgvaz]

Currently a hot-fix was implemented by simplying locking fastcore version to <1.1

[FraPochetti]

As far as I can tell we have only 2 occurrences of pathlib.Path.read() in the codebase: here and here.
Is this correct?

[FraPochetti]

If this is the case I can quickly patch it. It should be a matter of replacing .read() with either .read_text() or .read_bytes(). They both work with json.loads(...)

[lgvaz]

Is this correct?

I believe you're correct, I did a global search and the other reads that I found seem not to be related with Path

If this is the case I can quickly patch it.

That would be very much appreciated ❤️, I'm guessing that read_text returns a string just like read does right?

[lgvaz]

I also opened the reflecting issue on icedata.

It's not necessary to fix the issue there to fix it here, but I just wanted to let you know in case you're interested.

[FraPochetti]

Sure man! Will do that tomorrow ;). I will also check icedata.

I'm guessing that read_text returns a string just like read does right?

Yes.

[lgvaz]

Thanks!!

[lgvaz]

Should I assign the issue to you? So other people know it's already taken

[FraPochetti]

Yes please