Iceraven-browser: Swipe Up to Open Tab Tray

Created on 15 Sep 2020  路  3Comments  路  Source: fork-maintainers/iceraven-browser

What is the user problem or growth opportunity you want to see solved?

an option to open tabs simply by swiping tab like in this reddit post https://www.reddit.com/r/firefox/comments/islbb9/added_some_flair_to_firefox_for_android_and_some/?utm_source=share&utm_medium=web2x&context=3

How do you know that this problem exists today? Why is this important?

i have been using Kiwi browser along side Iceweasel and found Kiwi's swipe to open tab more ergonomic

Who will benefit from it?

user with swipe to change tab

enhancement good first issue help wanted

Most helpful comment

To see how a more complex gesture with custom animations is implemented, look at ToolbarGestureHandler which implements swipe to switch tabs (with the help of SwipeGestureLayout).

All 3 comments

That looks pretty cool, but I can't find any evidence that /u/Behave_or_else has published the code behind their excellent demo. The closest thing I can find is https://github.com/mozilla-mobile/fenix/pull/13370 which (also?) adds a swipe gesture as a way to open the tab tray. I'm not sure if @person808 who wrote that code has anything to do with /u/Behave_or_else.

If we can dig up the code for this (maybe by messaging them on Reddit? Maybe it just is that PR?) and glue it to the tab tray customization options that @abhijitvalluri has already written on our side (probably to let it be a swipe down when using tab tray from the top), it would definitely be cool to have more UI improvements.

That reddit user is not me and I think that post is just a UI mockup. My PR doesn't have a fancy animation/transition like the post does because AFAIK you can't control the animation when using BottomSheetBehavior. If someone wanted to take a crack at improving my implementation, I would suggest trying to upstream it 馃槃

To see how a more complex gesture with custom animations is implemented, look at ToolbarGestureHandler which implements swipe to switch tabs (with the help of SwipeGestureLayout).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Leviafan83 picture Leviafan83  路  8Comments

TheEvilSkeleton picture TheEvilSkeleton  路  11Comments

mackeev picture mackeev  路  6Comments

resynth1943 picture resynth1943  路  6Comments

cleanerspam picture cleanerspam  路  6Comments