I3status-rust: nvidia gpu block: temperature field ignores style

Created on 8 Oct 2018  Â·  7Comments  Â·  Source: greshake/i3status-rust

Hi there,

the temperature field of the nvidia gpu block seems to ignore the style set in the config.toml.
When the temperature is low it has a bright green background instead of the black background specified for all blocks.

fonts-and-rendering help wanted

All 7 comments

Can confirm this. Here is screenshot with green indication, but when temperature rising up it have the same color as whole bar.
DeepinScreenshot_select-area_20191110184612

I don't think this is a bug. The current implementation looks like this:

temperature_widget.set_state(match temp {
    0..=50 => State::Good,
    51..=70 => State::Idle,
    71..=75 => State::Info,
    76..=80 => State::Warning,
    _ => State::Critical,
});

That is, low temperatures are considered "good", not "idle". This is similar to how a full battery is marked "good". You can override this style in your config if you wish. I'm also open to making these threshold more configurable -- they seem pretty arbitrary to me at the moment.

IMHO if we swap Good <-> Idle it would look like it should. This what i mean, when temp >50C:
DeepinScreenshot_select-area_20191111003459

Yep, I'd be happy to take a PR switching them.

@tim77 Could you please try #615?

@tim77 Could you please try #615?

Missed message, will try today.

✅ https://github.com/greshake/i3status-rust/pull/615 definitely fixed this issue. Thanks a lot!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lovesegfault picture lovesegfault  Â·  7Comments

greshake picture greshake  Â·  6Comments

l4l picture l4l  Â·  6Comments

YodaEmbedding picture YodaEmbedding  Â·  4Comments

yawpitch picture yawpitch  Â·  4Comments