Hyrax: UV showing with video marked as representative media

[julesies]

Moved from: https://github.com/curationexperts/nurax/issues/273

Descriptive summary
For the UV to show, the representative media should be an image file. However this work's rep media is a video file. See https://nurax.curationexperts.com/concern/images/r494vk17h (also the URL changes when you click on it?).

Expected behavior: UV doesn't show but the video selected does.
Related:
https://github.com/curationexperts/nurax/issues/272

to reproduce:

1. Create a work with multiple files. images and video
2. set the representative (in the description tab AFTER SAVE) file to the video
3. view the work
4. UV shows, it shouldn't.

[hortongn]

Here is the discussion on a previous issue that I think led to the UV being shown on works where the representative file is not an image: https://github.com/samvera/hyrax/issues/2802#issuecomment-376190608

And this is where that change happened:
https://github.com/samvera/hyrax/pull/2846/files#diff-cd3c371abc5c4eafc5a0bbb1c4039539

[julesies]

@hortongn ah I see. I believe the meaning here is the "visibility status" not the file type status. So the comment right under clarifies when it should show (i think). Can you let me know how you read that?

[hortongn]

@julesies Yeah I think the discussion got misinterpreted as "show the UV whenever there's a viewable image attached." If we really don't want to show the UV when the representative is not an image, I think restoring these few lines would be a simple fix:
https://github.com/samvera/hyrax/blob/5d2c6a1838d3231d5f24a49d0a4e5897cdab7b45/app/presenters/hyrax/work_show_presenter.rb#L60-L62

[julesies]

I'm thinking the representative media should always be shown at the top of the work view.... do people agree? cc @vantuyls

use case: PDF paper with supplemental image files. You want the PDF to show at the top.

[vantuyls]

Agree with @julesies

[cjcolvar]

Looks like this was my fault from the comment that @hortongn linked. I'm glad we're fixing it!

[cjcolvar]

@hortongn Do you have cycles and want to make the fix? If not, I can pick it up.

[hortongn]

@cjcolvar I'll hop on this fix right now. Thanks!

[elrayle]

Fixed by PR #2971. Closing.