Hyperapp: Add linting script

Created on 17 Mar 2017  路  9Comments  路  Source: jorgebucaran/hyperapp

Awesome project! How would you feel about adding linting? Maybe as a pretest script. The code already conforms pretty well to standard style. Will be happy to make the PR.

Most helpful comment

@selfup summarized it perfectly 馃槃

All 9 comments

Hi @tiaanduplessis! Sorry for the lack of response. How would the project benefit from using a linter?

Also, the code does not conform to standard since I use " and not ', I guess I could change my habits and start using ', but I'd like your input/opinion about linters in general since I never use them.

@jbucaran it would help contributors know that their code is good to go before submitting a PR in terms of style, and also linters let people know if the variable they are referencing exists or not.

It's kind of like mild static typing in a way 馃槀

@selfup summarized it perfectly 馃槃

@jbucaran the standard config can also be extended and customized to suit your preference 馃憤

@tiaanduplessis @selfup Now that prettier supports semi: false out of the box, I've started using it. I'm using the vscode extension that formats my code on save.

Perhaps we could add a note on the wiki or add a CONTRIBUTIONS file with this info among other?

@jbucaran So glad you like the auto format. I love it too haha 鉂わ笍

yea we should add a CONTRIBUTIONS file 馃憤

Perhaps we could add a note

Can't we add a script that calls prettier? I'm assuming there is a CLI for it.

Now that prettier supports semi: false

Same here.

Does prettier support editorconfig?

@dodekeract Does prettier support editorconfig?

No idea, but it would be "_pretty_" good!

@tiaanduplessis We're using https://github.com/prettier/prettier now, are you familiar with it?

If you can still work on that PR that would be lovely! 馃檹

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jscriptcoder picture jscriptcoder  路  4Comments

jorgebucaran picture jorgebucaran  路  3Comments

VictorWinberg picture VictorWinberg  路  3Comments

icylace picture icylace  路  3Comments

jorgebucaran picture jorgebucaran  路  4Comments