Hyper: Escape key does not work in latest canary build on MacOS

[LudwigThePig]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: MacOS Mojave 10.14.6
• Hyper.app version: Canary (Feb 19th ish release)
• Link of a Gist with the contents of your .hyper.js: link to gist
• Relevant information from devtools N/A
• The issue is reproducible in vanilla Hyper.app: Yes

Issue

In the latest canary build, the escape key no longer performs the desired behavior (like exiting a mode in vim). I believe this is mapped to the close() dispatcher.

I dug around and I think it has something to do with this commit or some commit around that time.

If I switch back to the stable release, the exit button works.

Let me know if you'd like me to provide any other details or dig a little deeper.

Cheers,
Morgan

[lucactusss]

It also happens with Linux OS (Ubuntu 19.10) and with the latest canary build

[saamalik]

Use Ctrl+[ like a champ instead! =)

[bntzio]

Yep, it's happening to me as well.

[AaronRobinson]

And me

[nyc-tinker]

Can confirm also MacOS catalina doesn't work. Can confirm that <Esc> works in regular terminal, so it's a hyper-specific issue

[LabhanshAgrawal]

This was fixed in #4407
Try a newer build (e.g. https://github.com/zeit/hyper/actions/runs/77488656)
Reply if you face some issue.

[peppy]

As the current canary build is broken, I'd propose doing a new canary release with the fix included.

[LabhanshAgrawal]

New release might take some time, you can use the build from CI.

[LabhanshAgrawal]

@LudwigThePig
Were you able try out the ci build?

[peppy]

Can confirm it works again on the latest CI build.

[AaronRobinson]

Works for me after fresh download

Sent from my iPhone

On 24 Apr 2020, at 01:56, Dean Herbert [e-mail] wrote:


Can confirm it works again on the latest CI build.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

[LabhanshAgrawal]

@LudwigThePig can you also try it and close this issue if everything's good.

[saamalik]

Fixed it for me too!

On Fri, Apr 24, 2020 at 7:34 AM Labhansh Agrawal [e-mail]
wrote:

@LudwigThePig https://github.com/LudwigThePig can you also try it and
close this issue if everything's good.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zeit/hyper/issues/4332#issuecomment-619048299, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALDMLLHKDDOB7DMFFADSE3ROGPPXANCNFSM4K5DO4EQ
.

[andreasvirkus]

@LabhanshAgrawal This is still broken on the latest canary (3.1.0-canary.4) on macOS 11.1 - is canary release blocked? There hasn't been one in 11 months.

For now, Ctrl+[ is a workaround. Edit: there's also a config-level fix proposed here: https://github.com/vercel/hyper/issues/3929#issuecomment-694653861

keymaps: {
   'editor:break': 'esc',
},

[LabhanshAgrawal]

There're some issues blocking releases, you can get the ci build from https://github.com/vercel/hyper/actions/runs/461548454