Hyper: Tab do not respond & squash/stretching on resize

[nicobarray]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS Mojave 10.14.4
• Hyper.app version: 3.0.0 (stable)
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/nicobarray/fecc814d0dddd509e2c79e8d8e8aeb58

• Relevant information from devtools _(CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere)_:
  

• The issue is reproducible in vanilla Hyper.app: Unfortunately I couldn't.

Issue

After updating to hyper v3.0.0 I had a weird behavior when creating a new vertical pane (with Cmd+Shift+D shortcut). The previous pane (the top one) stopped updating and it was totally stretch and squashed when resizing the pane (when the new pane poped and manually too afterward).

Notes:
The scrolling on the pane is not working too.
Other pane on the same tab are working.
The previous pane was running some lerna/dev servers.

Here is a small kap of the describe behavior:

[ppot]

@juancampa need to update xtermjs version since it was fixed in a release

[nicobarray]

I had this issue again (even if @ppot says it is fixed I want to add more context until the issue is closed). It appears to only impact the top left pane (feels like it is the first node of the pane tree).

Here are some more devtools screens (showing another error type: Uncaught TypeError: Cannot read property 'replaceCells' of undefined)

[ppot]

@nicobarray I said it was fixed in xterm, not in hyper since it pull on older xterm release.

Also it's related to how hyper handle the xterm repaint. Since the first pane is not part of a group, it's parent get removed when there is a split made.

https://github.com/zeit/hyper/blob/canary/lib/components/term-group.js#L106-L120

[nicobarray]

Hi @ppot, just wanted to know if hyper will update its xterm version in a next patch or canary release ?

[LabhanshAgrawal]

We're on the latest xterm
can you try the latest ci build and confirm if it's fixed.

[nicobarray]

I'll install the ci build and tell you if something fails (or not 🎉 ). Thanks for the work!

[LabhanshAgrawal]

confirmed to be fixed, in #3951
Feel free to open a new issue if you face any other problem