Hyper: Inverted colors repeat first character of the string

[dcalhoun]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS 10.14.1 (18B75)
• Hyper.app version: 2.1.0-canary.3
• Link of a Gist with the contents of your .hyper.js: TBD
• Relevant information from devtools _(CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere)_: n/a
• The issue is reproducible in vanilla Hyper.app: Have not tested it yet.

Issue

Originally reported in #3255, strings that are highlighted (i.e. the background/foreground colors are inverted), the first character of the string is repeated instead of the entire string.

The following is example output from running jest#23.6.0.

Expected (macOS Terminal)

Actual (hyper#2.1.0-canary.3)

[chabou]

Oh... Very nice related analyze. Thank you!
I was supposing that It was only concerning pasted chars (and acceptable to release).

Certainly a xterm issue.

[chabou]

I noticed that inverted color doesn't work at all if background is not opaque:

[dcalhoun]

@chabou I wonder if it is related to the fact that Jest inverts the "default terminal font color"? It's possible that it is unrelated and still an issue with xterm. I have no idea.

[chabou]

Repeated char is certainly related to their dynamic atlas.
But I can't reproduce it in VSCode.

So maybe, Hyper initializes xterm badly.

[chabou]

Repeated char on paste doesn't happen with xterm v3.7.0

Transparent inverted char still happens but happened with previous hyper release.
Understandable because xterm is using background color and hyper force transparent background colorfor term if user bg color is not opaque (and set background color to its own body). It prevents some overlapping between non-opaque layers.

[edsu]

I'm seeing this when using the Unix utilityless as well:

% less deletes.csv

I tried disabling my theme and color configuration but still see the same behavior.

[olivier-w]

I'm seeing the same thing every time I paste something in Hyper. Here's an example, running Hyper 2.1.0-canary.3 (canary) on 10.14.1

[olivier-w]

Did a little digging, looks like https://github.com/xtermjs/xterm.js/releases/tag/3.9.0 merged 30mins ago, would that fix this issue? Based on this comment: https://github.com/zeit/hyper/issues/3316#issuecomment-445837330

[chabou]

@olivier-w thank you! I will try it ASAP!