Hyper: Hyper CLI doesn't print a newline after unknown options

Created on 25 Jun 2018  路  9Comments  路  Source: vercel/hyper

  • [x] I am on the latest Hyper.app version
  • [x] I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 Pro (1803) / WSL (Ubuntu 4.4.0-17134-Microsoft)
  • Hyper.app version: 2.0.0
  • Link of a Gist with the contents of your .hyper.js: clean install, uses bash
  • Relevant information from devtools _(CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere)_: N/A
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

When running a command such as hyper -i hyperline an error occurs (the correct command is obviously hyper i hyperline). The error is printed without a trailing newline.

~/Documents/GitHub$ hyper -i hyperline
-The option "i" is unknown.~/Documents/GitHub$
+The option "i" is unknown.
+~/Documents/GitHub$
help wanted Bug 馃憜 Is Upstream

Most helpful comment

After concluding that the Hyper source has no instance of any log close to the error I'm seeing, I've been looking through all the dependencies and I think I found the culprit.

In the source of the dependency args I found the following code here:

process.stdout.write(`The option "${option}" is unknown.`)

I've opened an issue in that repository (https://github.com/leo/args/issues/129). Perhaps this issue should remain open until the upstream error is fixed.

The difficulty of the fix is the same as it would be here, perhaps @thefifthisa would be interested in fixing the issue?

All 9 comments

Hi, I'm new here and would like to take this!

@thefifthisa Hi 馃憢 馃樃 feel free to help 鉂わ笍

If you need help or have any questions, let me know :)

Thanks, @MAPESO! I'm actually having trouble recreating this error. Here's what I get on bash and git bash:

bash
gitbash

Am I missing something?

@thefifthisa You鈥檙e not missing anything, your output seems to be correct. Are your versions (hyper, windows etc) similar to those I mentioned in the description?

@AlexGustafsson Yup! Also on Windows 10 (Home) and Hyper 2.0.

After concluding that the Hyper source has no instance of any log close to the error I'm seeing, I've been looking through all the dependencies and I think I found the culprit.

In the source of the dependency args I found the following code here:

process.stdout.write(`The option "${option}" is unknown.`)

I've opened an issue in that repository (https://github.com/leo/args/issues/129). Perhaps this issue should remain open until the upstream error is fixed.

The difficulty of the fix is the same as it would be here, perhaps @thefifthisa would be interested in fixing the issue?

Upstream was closed as not an issue, but this one is still open 馃槄

Closing as upstream issue https://github.com/leo/args/issues/129 is closed
Feel free to open a new issue if you face any problems

Was this page helpful?
0 / 5 - 0 ratings

Related issues

laur1s picture laur1s  路  3Comments

sarneeh picture sarneeh  路  3Comments

juicygoose picture juicygoose  路  3Comments

legomushroom picture legomushroom  路  3Comments

dbkaplun picture dbkaplun  路  3Comments