Hyper: The popup about canary version is annyoing, can't disable that!

[szmarczak]

Ubuntu 18.04 LTS, Hyper 2.0.0 (Stable), default settings.

It is so annoying, every time Hyper launches I have to click [x] which is almost invisible because of the color it has. Please add a setting to disable notifications about canary versions.

[asachs01]

Agree. I would love to have this stop showing up.

[albinekb]

Hmm, are you sure you don't have updateChannel: 'canary' in your .hyper.js?

[szmarczak]

@albinekb Yes, I am sure :D Here's full .hyper.js

    // choose either `'stable'` for receiving highly polished,
    // or `'canary'` for less polished but more frequent updates
    updateChannel: 'stable',

[albinekb]

Here's the lines that fetches and displays the message, can't see anything directly that looks wrong 🤔 needs some investigation

https://github.com/zeit/hyper/blob/canary/app/notifications.js#L4-L35

[albinekb]

@chabou do you know what code is running at https://hyper-news.now.sh ? 🤔

[szmarczak]

@chabou @albinekb fetchNotifications emits this:

{ "text": "Version 2.1.0-canary.1 is available. New `lineHeight` option, improvements and bug fixes based on feedback ⚡\r",
  "url": "https://github.com/zeit/hyper/releases/tag/2.1.0-canary.1",
  "dismissable": true,
  "versions": ["< 2.1.0-canary.1"],
  "platforms": ["linux"]
}

[albinekb]

Thanks for checking that @szmarczak, looks like there's a bug in https://hyper-news.now.sh 🤔

[chabou]

Newsfeed was used as a fallback because Linux version doesn't have an auto-updater.
But it doesn't work well since we have canary releases.

But now, Hyper uses hazel endpoint on Linux too (thanks to #2497).
We need to modify our Newsfeed to not announce new versions anymore.

Any ideas how we can do that @matheuss @rauchg?

[albinekb]

Maybe re-deploy a new micro that just responds with an empty string as message? 🤔

[MKRhere]

I feel I'm missing something here. Why not add a config option to disable fetching notifications at all? Why request an empty message?

[chabou]

@MKRhere because you want to disable notification because of this bug. We should fix this bug (notification about a canary update even if you are on the stable channel).
If we permit to disable notifications, it will lead to not show useful and healthy notifications and we'll have a lot of outdated app.

[MKRhere]

I see. But this has been a long time bug. I'd actually like to dismiss notifications permanently after once. Hmm.

I mean when I open a terminal session, the last thing I want to keep getting is an update notification.

[jaydh]

I think the middle ground here would be a 'Don't Show Again' option for notifications.

[albinekb]

That's a great idea @jaydh, I think that would work. We could save the an hash of the text inside the settings maybe in an array? @chabou what do you think of implementing this?

[chabou]

I think that we should reevaluate the need to dismiss (or disable) notification after fixing this shameful and awful bug.

[matheuss]

@chabou The code is at https://github.com/zeit/hyper-news. I'll move the deployment and alias over to the hyper team on Now so you can control them 👌

[matheuss]

@chabou done :v: