Hyper: Configure line height

[hankchizljaw]

• [X] I am on the latest Hyper.app version
• [X] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS High Sierra 10.13.3
• Hyper.app version: Hyper 2.0.0 (stable)
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/hankchizljaw/d1733306ae06854a6ae9d1304bbd0844

Issue

Hey Hyper Team,

First of all, the new version looks excellent, so thank you for your ongoing hard work on this 👏

Now that we've got a canvas based rendering system, is it any simpler to increase the line height at all?

Here's two screenshots of Vim, the first using iTerm and the second user Hyper 2.0

iTerm

Hyper

[msikma]

As mentioned by @Spaxe in #75, xterm 3.0 exposes a lineHeight option. It doesn't look like it's being passed on, though, since defining it in the config doesn't do anything.

[piotr-yuxuan]

I wonder how such a minor-looking issue (allow to change the height of a line) can still not be resolved after more than one year and a half -- see https://github.com/zeit/hyper/issues/75 which still generates quite a lot of activity. What would be the best way for the community to offer help to the maintainers so this long-running issue could be addressed?

[hankchizljaw]

2858 looks like a decent solution. Let's hope this is resolved soon, as I'd love to use Hyper as my primary terminal 🙂

[albinekb]

@piotr-yuxuan because it's not used by a lot of people. Feel free to create a PR. Now we have #2858 so it will be in soon. We're all doing this in our spare time and for free.

[piotr-yuxuan]

Please forgive the tone of my previous message which was too cold. I know we all contribute for free in our spare time :-)