Hyper: Hyper 2.0 shows wrong colors

[rdev]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS 10.13.3
• Hyper.app version: Hyper 2.0.0 (stable)
• Link of a Gist with the contents of your .hyper.js: My .hyper.js
• Relevant information from devtools N/A
• The issue is reproducible in vanilla Hyper.app: Yes

Issue

I'm using Hyper with Fish shell and this OMF theme
And since 2.0 update some colors are displayed incorrectly:

Here's iTerm (Hyper < 2.0 looked the same):

And on 2.0.0 the "❯" symbol is cyan:

It seems like #2bed9b color from the shell is swapped with lightCyan by Hyper

[albinekb]

I can't see #2bed9b in your config 🤔

[rdev]

@albinekb it's not part of the config, it's in the Fish theme

Check here:
https://github.com/rdev/omf-theme-one/blob/f47998520622948c7a4259a761c6f7d27d603859/fish_prompt.fish#L1-L12

[connorwiebe]

yeah all the colors look faded/washed out for me too in 2.0

[albinekb]

@rdev hmmm I wonder why that doesn't work. Thanks for pointing me there

All colors or just bold color? that could be https://github.com/zeit/hyper/issues/2836 @connorwiebe

[rdev]

@albinekb all colors

[chabou]

@rdev It seems that you fish theme uses TrueColors and this is not compatible yet with our underlying terminal xtermjs

@connorwiebe default colors have changed to match iTerm2 theme (and permit use of brightColor). https://github.com/zeit/hyper/pull/2670#issuecomment-382714834

[ArondeParon]

Similar issues here with ZSH and Agnoster theme.