hyperborder plugin is not compatible with v2

Created on 16 Apr 2018  ยท  8Comments  ยท  Source: vercel/hyper


  • [x] Your Hyper.app version is 2.0.0. Please verify your using the latest Hyper.app version
  • [x] I have searched the issues of this repo and believe that this is not a duplicate

  • Any relevant information from devtools? _(CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere)_:

  • Is the issue reproducible in vanilla Hyper.app?

Issue

  • Hyper version: undefined "2.0.0"
  • OS ARCH VERSION: darwin x64 17.4.0
  • Electron: 1.8.4 LANG: undefined
  • SHELL: /usr/local/bin/zsh TERM: undefined


    ~/.hyper.js contents


    {
    "updateChannel": "stable",
    "fontSize": 12,
    "fontFamily": "Menlo, \"DejaVu Sans Mono\", Consolas, \"Lucida Console\", monospace",
    "cursorColor": "#6BC6F9",
    "cursorShape": "UNDERLINE",
    "cursorBlink": false,
    "foregroundColor": "#fff",
    "backgroundColor": "#000",
    "borderColor": "#333",
    "css": "",
    "termCSS": "",
    "showHamburgerMenu": "",
    "showWindowControls": "",
    "padding": "12px 14px",
    "colors": {
    "black": "#000000",
    "red": "#ff0000",
    "green": "#33ff00",
    "yellow": "#ffff00",
    "blue": "#0066ff",
    "magenta": "#cc00ff",
    "cyan": "#00ffff",
    "white": "#d0d0d0",
    "lightBlack": "#808080",
    "lightRed": "#ff0000",
    "lightGreen": "#33ff00",
    "lightYellow": "#ffff00",
    "lightBlue": "#0066ff",
    "lightMagenta": "#cc00ff",
    "lightCyan": "#00ffff",
    "lightWhite": "#ffffff"
    },
    "shell": "",
    "shellArgs": [
    "--login"
    ],
    "env": {},
    "bell": "SOUND",
    "copyOnSelect": false
    }

    {
    "plugins": [
    "hyper-snazzy",
    "hyperborder",
    "hyper-blink",
    "gitrocket",
    "hyper-confirm"
    ],
    "localPlugins": []
    }


Most helpful comment

@chabou, I'm trying to debug why Hyperborder no longer works. Is there a plugin migration guide? Judging by the info on Hyper - Extensions API, the plugin should still work.

When debugging into the Hyperborder code, I see that decorateConfig(config) is now never called by Hyper. Is this an expected API change? That's where the crux of the Hyperborder logic lives.

All 8 comments

Getting black screen here, updated it just right now.

screen shot 2018-04-16 at 17 21 00

Please try without any plugin

@chabou Working now, the plugin hyperborder is causing the issue.

@ppamorim it was exactly this plugin, yes! But I liked this plugin.... sniff

We sadly expect that some plugins are now broken. We hope that they'll adapt quickly.

Yes, I hope so. Thanks for your answers. I close this issue.

@chabou, I'm trying to debug why Hyperborder no longer works. Is there a plugin migration guide? Judging by the info on Hyper - Extensions API, the plugin should still work.

When debugging into the Hyperborder code, I see that decorateConfig(config) is now never called by Hyper. Is this an expected API change? That's where the crux of the Hyperborder logic lives.

I am pretty sure than decorateConfig is working. Most of the themes are using this to set their colors.

There are some good recipes here: https://github.com/zeit/hyper/blob/canary/PLUGINS.md

From what I saw, your css is broken.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

laur1s picture laur1s  ยท  3Comments

alejandrofloresm picture alejandrofloresm  ยท  3Comments

juicygoose picture juicygoose  ยท  3Comments

cilice picture cilice  ยท  3Comments

legomushroom picture legomushroom  ยท  3Comments