Hyper: deja vu sans hides underscore

[yoyoys]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate
• OS version and name: ubuntu 17.10
• Hyper.app version: 2.0.0-canary.15
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/yoyoys/a0d4dee0cabc82c4ac559ff35b934ab5
• Relevant information from devtools _(CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere)_: N/A
• The issue is reproducible in vanilla Hyper.app: Vanilla

Issue

deja vu sans mono is my favorite font for monospace.
and i prefer 14px for console, but the underscore will gone

Here's the screenshots

16px

14px

build-in terminal 14px

[chabou]

I can't reproduce on macOS.
@yoyoys Can you try to reproduce with a vanilla bash?

[yoyoys]

thanks.
here is the screenshot

[yoyoys]

it's funny, but i can see underscore in 12px

12px

I tried to render same text in chrome, and notice that the font width is not the same, is it a problem?

[yogeshkotadiya]

Can confirm this

• OS : Ubuntu 18.04
• Hyper : Hyper 2.0.0 Canary-16

Font Family : DejaVu Sans Mono
Font Size : 14

Default Config
No plugins

On Windows 10 No Issues ✔️

EDIT

I have the same issue in VSCode so it seems like it's an Xterm issue
Changing "window.zoomlevel" : -0.001 fixed the issue in VSC

Adding the property like that into hyper config for window zoom will fix this issue.

[lanthaler]

I have the same issue on Debian. I also tried installing the 2.1 canary and change the line-height. That increased the line-height but still cut off the underlines. I assume there's some styling issue (overflow hidden?) in xterm due to a rounding error for some font-sizes. It works fine for font size 13 and 15, just 14 has the issue.

[summershrimp]

not fixed at 2.1 stable
Ubuntu 18.04

[summershrimp]

Can confirm this

• OS : Ubuntu 18.04
• Hyper : Hyper 2.0.0 Canary-16

Font Family : DejaVu Sans Mono
Font Size : 14

Default Config
No plugins

On Windows 10 No Issues

EDIT

I have the same issue in VSCode so it seems like it's an Xterm issue
Changing "window.zoomlevel" : -0.001 fixed the issue in VSC

Adding the property like that into hyper config for window zoom will fix this issue.

How to change zoomelevel in hyper.sh?

[irfanfadilah]

I can confirm this bug too.

• Ubuntu 14.04
• Font Size 14px

[mindware]

I can reproduce on:
Hyper version 2.1.2
On Ubuntu 18.04.2 LTS

I simply use zoom ( CTRL + and CTRL -) and there is a zoom level in which the _ is invisible.

[eddo888]

on a mac with Deja vu sans mono at 10, the underscore reveals itself if you down/up arrow in the middle of typing (bash complete ish).
To fix the issue I selected "bold" and the underscore appears as typed.
Weird to say the least.

[Stanzilla]

Can you try with a CI build of current canary or maybe compile one yourself?

[kulaj]

this still happens, Hyper 3.0.2, Ubuntu 19.10. Deja vu sans should be removed as a fall-back. Undescroes render properly when it is taken out

[jocull]

this still happens, Hyper 3.0.2, Ubuntu 19.10. Deja vu sans should be removed as a fall-back. Undescroes render properly when it is taken out

If it is falling back, what font is it falling back to?

[bduffany]

Can confirm that this is still an issue on Hyper version 3.0.2, Ubuntu 20.04, DejaVu Sans Mono. For me, it's only an issue with 12px font size.