Hyper: built-in hyperlinks alternative not working properly

[SirWindfield]

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: OS X Sierra 10.12.6
• Hyper.app version: Hyper 2.0.0-canary.14 (canary)
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/SirWindfield/32176f589d86e1897a540ef92e365104
• Relevant information from devtools N/A
• The issue is reproducible in vanilla Hyper.app: yes

Issue

It looks like the built-in hyperlinks alternative in v2 has still some errors/bugs. The link does not get highlighted using another color as hyperlinks did it in version 1.4 of Hyper.
Clicking a link and holding the CMD/Control key does not open the link within Hyper itself but rather in the default browser.

I am not sure if these features have already been added or are on some kind of Todo list already. Just wanted to make sure :smile:

Edit:
Here are two images of hyper 1.4 and 2.0 showing the differences:

The first one is hyper running on version 1.4, the second one on 2.0 canary. The third one is the CMD/Control click on the link that will open the url within hyper itself.

[chabou]

Thank you for your feedback!

After some discussions about some security concerns, we abandoned the idea of browsing websites directly in Hyper.

Electron webview is not enough secure (old Chrome version, potential API leaks in website JavaScript context...).

We are really unhappy to remove this shining feature, but as a terminal app, security is non-negotiable.

[gustavoFreireS]

I did a local plugin to reproduce the older behavior using an iframe component, Am I still vunerable to this kind of security problems?

[albinekb]

There's so much going on in electron so I would say, yes you're vulnerable if you open web pages in electron. Will it matter? Most likely not.