Hyper: SSH url scheme handling should not be added on dev mode

[chabou]

Since #2516, Hyper is set as default program to handle ssh:// url scheme.
It should not be done on dev mode.
Condition should be added here:
https://github.com/zeit/hyper/blob/0162a9f84dab44a5be395f4faf7579217822e5a6/app/index.js#L186-L195

cc @antonioalmeida

[ajomadlabs]

Can I take up this issue

[antonioalmeida]

Sure @ajomadlabs, you just need to check isDev, before applying the change

[ajomadlabs]

@antonioalmeida Since this is my first issue, can you provide some resource, where to start off

[diogotorres97]

@ajomadlabs literally do:
if (! isDev){ line 188,189}
else
nothing;

Same thing to second case

Or better add a condition like:
if (config.getConfig().defaultSSHApp && !app.isDefaultProtocolClient('ssh') && !isDev)

[antonioalmeida]

https://github.com/zeit/hyper/blob/0162a9f84dab44a5be395f4faf7579217822e5a6/app/index.js#L186-L195

As @chabou mentioned, in this area you should check if Hyper is running on dev mode, and prevent the chances if so. To do this, you can check isDev's value, similar to what is done here:
https://github.com/zeit/hyper/blob/0162a9f84dab44a5be395f4faf7579217822e5a6/app/index.js#L88-L108

Is that clear?

[chabou]

@ajomadlabs Let's do this!
@antonioalmeida thank you so much for your insights and helping a new contributor.

You're all awesome 🙌

[ajomadlabs]

@chabou I created a pull request https://github.com/zeit/hyper/pull/2745. Please do suggest me changes if any

[antonioalmeida]

@chabou no problem! 👍
good job @ajomadlabs