Hyper: Disable notifications completely

[bootstraponline]

Editing ~/.hyper.js with Save on Change produces an endless stream of notifications and bell sounds. There should be an option to completely disable notifications, not just the sound. bell: false, does nothing.

[chabou]

Hi there, thanks for reporting an issue!
Unfortunately, we need the information that was listed out in template when you created the issue to really help solve your problem. For now, we'll close your issue and wait for you to comment/re-open the issue with the template information filled out from https://github.com/zeit/hyper/issues/new

[tborychowski]

@chabou

After your comment I doubt the guy would use your app again :-)
Have you tried it on mac?
Were you able to disable notifications?
Well, we weren't.

Still need more info from your template?
Here you are:

• [x] I am on the latest Hyper.app version
• [x] I have searched the issues of this repo and believe that this is not a duplicate
• latest macos
• Hyper 1.4.8 (stable)
• Link of a Gist with the contents of your .hyper.js: default.
• Relevant information from devtools nothing
• The issue is reproducible in vanilla Hyper.app: YES

And now, don't be a ** and fix the notifications :-)

[albinekb]

Ok so now we know:

• Hyper 1.4.8
• Happens on mac (probably windows too, needs confirmation)
• Only gets annoying because of "save on change"

So, I see a couple of options:

• Add a config option to disable notifications?
• Debounce the notification
• Close this issue and tell users not to use save on change when editing hyper config

Save on change is not a good idea with hyper config as we parse it and do a couple things with the config every time we detect a change, which could lead to performance issues and other racey conditions. So personally I think it's best just to tell the author and similar here not to use save on change with hyper 👍

Thoughts? 🙂

[bootstraponline]

A config option to disable notifications would be nice.

[tborychowski]

Actually I don't mind notifications when they are useful (e.g. when a command exited with status !== 0).
But there's one showing up when I even open the settings file (in ST3).

So I think it would be better, instead of true | false, to have sth. like a log-level: INFO, WARNING, ERROR and NONE.
Where the first one would notify on everything, whereas the last one on nothing.

[bootstraponline]

If we go with log level, there should be NONE as an option to completely disable notifications.

[tborychowski]

thanks @bootstraponline, updated my comment :-)

[ajcrites]

Does this mean that there is currently no way to stop or silence Hyper notifications?

[bootstraponline]

Does this mean that there is currently no way to stop or silence Hyper notifications?

Right

[BrainInBlack]

Why is this still an issue? It is clear that the config option "bell: false" has no effect whatsoever and needs fixing.

With that out of the way, why use system notifications in the first place? It's not like that there is not enough room in the hyper UI for a small icon in one of the corners, with a little pop-up, that could be used for notifications and error messages.

notifications: none|system|application
notificationsLocation: topLeft|topRight|bottomLeft|bottomRight

This way everybody is satisfied, people who like the "old" way with system notifications, people who like in app notifications and people who don't want notifications at all.

[albinekb]

PR welcome @BrainInBlack 😊

[sgarcia-dev]

So...does someone have an update on this? Doesn't look like this had any resolution, and I'm kind of surprised a simple updateNotifications: false flag still doesn't exist...

[bootstraponline]

The issue is tagged as awaiting response. A boolean flag that disables all notifications will resolve the issue. It sounds like someone will have to submit a PR.

[olealgoritme]

This is clearly a much needed feature. It seems to have a multitude of implications, like with my Window Manager in Linux - which does not run a Notification Daemon Service - which is needed to display notifications.

Without the Notification Daemon Service you will encounter a lot of lockup and freezes with Hyper.
For now, I'll just disable the notifications entirely.

https://github.com/zeit/hyper/blob/canary/app/notify.js#L8-L11
:laughing:

https://electronjs.org/docs/api/notification#notificationissupported
Yes, Electron has it's own Notifications. Maybe use that instead of this "hack"?

https://github.com/zeit/hyper/blob/canary/app/notify.js#L33-L45
For those who want to remove it, just disable this / comment out / replace, whatever.

[Place1]

I was about to try out Hyper on macos but everytime i saved my config file I got a notification. Hyper looks really cool but this isn't a great first impression.

Perhaps I can contribute a flag if someone can point me in the right direction?

[proteriax]

@Stanzilla Why is this issue closed?

[JuanVqz]

@proteriax Are you having this problem? or Do you solve it?
because I set bell: false and it still doing the "Beem" sound